Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mode for trigger ? #202

Open
wardru opened this issue Dec 4, 2024 · 1 comment
Open

Wrong mode for trigger ? #202

wardru opened this issue Dec 4, 2024 · 1 comment

Comments

@wardru
Copy link
Member

wardru commented Dec 4, 2024

[my_psu] 'measure/voltage/trigger' - command received 'true'
Fake Ask "VOUT1?"
Fake behaviour not supported "VOUT1?" > do nothing
Fake Ask - return "1"
[my_psu] 'measure/voltage/trigger' - command received 'false'
[my_psu] 'measure/voltage/trigger' - command received 'false'
[my_psu] 'measure/voltage/trigger' - command received 'false'

It seems like trigger cannot be set to false, which make sense.
But its mode is RW currently and the app doesn't like that.

Shouldn't it be WO ?

@wardru
Copy link
Member Author

wardru commented Dec 4, 2024

I'm thinking that it's weird for trigger to be a boolean, it's more a notifier, like just a send, regardless of the value.
Because on the UI if I have a WO mechanism to send either true or false, it's confusing.
I would like trigger to just have a trigger button. Should it be a special attribute ? Forced to be WO and with an empty payload kindof ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant