Fix vanilla parity on enchantable items with no targets #11896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
reviewed
Jan 4, 2025
paper-server/patches/sources/net/minecraft/world/inventory/EnchantmentMenu.java.patch
Outdated
Show resolved
Hide resolved
|
Yeah, this is just a fundamental problem with how EnchantmentOffer is structured. It should've never been nullable in the array and instead had a nullable enchantment so the cost could still be set. I think it's fine to just revert to handle it like vanilla. |
|
Is there maybe a point in only yanking the cost if the cost wasn't present pre-event call? To allow the native vanilla layout for enchantable items without breaking plugins that actively want the offer to not be sent? Given this API will just need to be deprecated anyway, a bit of salvaging might be worth minimal breakage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #11821
Previously after the enchantment event took place bukkit would clear out all empty enchantments and send a completely empty offer list to the client. Minecraft handles this differently by default by still sending a cost to the client so the slots illuminate as seen in the attached issue.
This pull request attempts to address this issue by not setting back enchantment offer cost to 0 after PrepareItemEnchantEvent. This keeps the original price that was generated through the loop earlier within the slotsChanged method.
As far as drawbacks go for this fix after looking into this it would largely be thinking about how things are handled event side, because something would need to be done. If a developer wants to null out a spot how do we address this while maintaining vanilla behavior when an item may have no offers available? Or should vanilla behavior be kept to start with?
For reference when blanking out all 3 offers an enchanment table now looks like this, client side the hover shows no enchantment names, however displays all levels.
@EventHandler fun onEnchant(event: PrepareItemEnchantEvent) { for (index in event.offers.indices) { event.offers[index] = null } }within default vanilla behavior as far as I'm aware there is no scenario where three enchantments aren't sent.