feat: Dialog API documentation #621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Strokkur424
force-pushed
the
feat/dialogs
branch
from
012e0dc to
ac6e072
Compare
mbax
reviewed
Jul 12, 2025
mbax
reviewed
Jul 12, 2025
| The type primarily influences the bottom part of the dialog. | ||
|
|
||
| ## Registering dialogs in the registry | ||
| If you want dialogs to be registered in the dialogs registry, you have register them inside a registry modification lifecycle |
There was a problem hiding this comment.
Should we add a remark reminding about needing to do this for the dialogList type?
There was a problem hiding this comment.
Also, "you have to register" but maybe instead "you must register"
There was a problem hiding this comment.
You don't have to do it for the dialog list type. You can use a RegistryValueSet and just have a list of directly created ones.
mbax
reviewed
Jul 12, 2025
mbax
reviewed
Jul 12, 2025
| ``` | ||
|
|
||
| ### Reading the input | ||
| To retrieve the values the user put into the dialog, we once again have to listen to a `PlayerCustomClickEvent`. |
There was a problem hiding this comment.
What about custom click action with the callback built in, instead of listening to the event?
Machine-Maker
requested changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.