Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Add proper comment handling for files (Both replacement for Grammar files and File-Analysis commands) #10

Closed
Luna-Klatzer opened this issue Jul 18, 2021 · 2 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@Luna-Klatzer
Copy link
Member

This is an alternative solution to the bugs currently caused by the comment handling in the syntax analysis command. Another solution proposed here #9

Summary:
Implementation of a pre-scan of files to remove comments before processing to ease out handling in Antlr4 and make it easier for the Grammar files to properly handle such cases. This could also replace the current comment implementation in the grammar files, due to removing them before starting to process.

This scan or rather a function would go through a file and remove any multi-line or single line comments clearly visible through the reversed characters // and /* including */

@Luna-Klatzer Luna-Klatzer self-assigned this Jul 18, 2021
@Luna-Klatzer Luna-Klatzer changed the title Add proper comment handling to syntax analysis Add proper comment handling for files (Both replacement for Grammar files and File-Analysis commands) Jul 18, 2021
@Luna-Klatzer Luna-Klatzer added bug Something isn't working dev idea Theoretical feature, idea etc. and removed idea Theoretical feature, idea etc. labels Jul 18, 2021
@Luna-Klatzer Luna-Klatzer linked a pull request Jul 19, 2021 that will close this issue
Luna-Klatzer added a commit that referenced this issue Jul 20, 2021
@Luna-Klatzer
Copy link
Member Author

Closing due to #13 being finished and tests proofing working implementation.

@Luna-Klatzer
Copy link
Member Author

Moved issue to #16

@Para-Lang Para-Lang locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant