Laundry list of performance stuff from a tracy run on 2022-12-28

[AffectedArc07]

This discussion will contain separate posts for each thing I (and anyone else who downloads the trace) finds about the codebase in that round for stuff that can be optimised to majorly speed the game up with.

If you want the trace, you can download it from https://mocha.affectedarc07.co.uk/box2022_12_28.7z, however you will need 32GB of RAM to view it. This is not a joke

Round was 34039

---

If you are going to post procs that are in need of optimisation, ask yourself:

• is this even possible to be optimised
• is there gameplay impact
• is it even worse optimising (there's no point shaving 10 microseconds off something called once, however 20ms off something called regularly is well worth it)

[AffectedArc07]

Keybinds menu is hyper slow

[AffectedArc07]

Fixed in #20034

[AffectedArc07]

Airlock controllers burn CPU on overlay updates they dont need

[AffectedArc07]

Fixed in 05ef052

[AffectedArc07]

Investigate logging is expensive as hell because it does file IO for some dumb reason

/atom/proc/investigate_log(message, subject)
	if(!message)	return
	var/F = investigate_subject2file(subject)
	if(!F)	return
	GLOB.investigate_log_subjects |= subject
	F << "<small>[time_stamp()] \ref[src] [ADMIN_COORDJMP(src)] </small> || [src] [message]<br>"

Reasoning was this, 11 years ago (foreshadowing??)

This should either just be a list in ram, or log with rust_g to investigate.log, or both.

[AffectedArc07]

Fixed in 0db3259

[AffectedArc07]

Both pathing needs the overlay creation removed (check with design team, denth approved already)

They dont render properly, arent visible for 99% of people, and wastes ~3ms per bot.

[AffectedArc07]

Fixed in 0db3259

[AffectedArc07]

New character saves dont need their hair randomising, especially when 30 of them are made on login

[AffectedArc07]

Fixed in 0db3259

[AffectedArc07]

SSinstancing needs a config to enable or disable DB data updating.

We burn a lot of the tick for data we are never gonna use.

[AffectedArc07]

Fixed in 0db3259

[AffectedArc07]

/client/New needs an investigation on the whole

Theres 5 different variation spikes here, one of which quite high up the tick usage

[AffectedArc07]

Figuring out WHAT THE HELL IS THIS

[AffectedArc07]

/datum/controller/subsystem/debugview/fire(resumed) can be optimised heavily.

It generates all this info every tick despite there being no viewers 99% of the time.

Adding a if(!length(processing)) return check to fire() will be an easy fix.

[AffectedArc07]

Fixed in 0db3259

[AffectedArc07]

This could do with being subsystemised, it made the MC skip ticks!!

[AffectedArc07]

[AffectedArc07]

/mob/living/carbon/human/proc/set_species has potential for major optimisation

update_body() is called this many times and is only needed once, mobs could do with a way to halt icon updates and do them all in 1 go at the end.

[AffectedArc07]

This also happens on mob spawners

[AffectedArc07]