Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove #2629 signal handler from interchange #3588

Open
benclifford opened this issue Aug 16, 2024 · 1 comment
Open

remove #2629 signal handler from interchange #3588

benclifford opened this issue Aug 16, 2024 · 1 comment

Comments

@benclifford
Copy link
Collaborator

PR #2629 added a force of signal handler because it needs to deal with being launched by multiprocessing.fork. PR #3463 makes interchange into its own process, which should get default signal handlers anyway (?) and so I think there's no need for this additional complication.

cc @rjmello who has looked at interchange start/exit the most recently

@rjmello
Copy link
Member

rjmello commented Aug 19, 2024

Your reasoning sounds right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants