Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The AccountRoutingSettings.AddEndpoint implements too many concerns #1011

Open
boblangley opened this issue May 26, 2023 · 0 comments
Open
Labels

Comments

@boblangley
Copy link
Member

Describe the suggested improvement

The AddEndpoint command is used to both provide routing details for endpoints on other accounts for commands (1st concern) and also inform subscriber endpoints which account to use (2nd concern) as well as configuring the subscription table name used in the other account (3rd concern).

Is your improvement related to a problem? Please describe.

Describe the suggested solution

AddEndpoint should be changed to just handle the concern of routing commands to endpoints on other accounts.
One or more methods should be added to configure publisher details:
A method should be added to register message types to be subscribed from other accounts, and should not require the publisher endpoint name.
Either an optional parameter on the previous method or a new method should be added to configure the subscription table name used in the other account.

Describe alternatives you've considered

Keeping things the way they are.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant