Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReceiverSettingsValidation and poison queue fallback logic might need a closer look #1139

Open
danielmarbach opened this issue Mar 13, 2024 · 0 comments

Comments

@danielmarbach
Copy link
Contributor

Describe the suggested improvement

ASQ validates early on the settings for the poison queue

ValidateReceiversSettings(receiversSettings);

but later then has sane fallback strategies to discover sensible defaults

https://github.com/Particular/NServiceBus.AzureStorageQueues/blob/a7de739961f1a87552a78f4c2bee37eefe30b76d/src/Transport/AzureStorageQueueTransport.cs#L231C1-L233

those sensible defaults though are not using the Core error queue fallbacks by leveraging https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Recoverability/Faults/ErrorQueueSettings.cs#L19. Furthermore, from a lower level transport seam implementation each receiver is allowed to have their own error queue but the fallback logic does a FirstOrDefault which could lead to inconsistent or surprising behavior.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant