You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Transport requires the serializer to be defined in the EndpointConfiguration or a custom serializer to be configured to handle message wrapping before sends
#524
Open
mauroservienti opened this issue
Feb 19, 2021
· 0 comments
Transport currently relies on the serializer defined in the EndpointConfiguration or a custom serializer configured to handle message wrapping before sends. The problem is that the serializer is defined using the SerializationDefinition Core type, which, in order to be used, requires an Endpoint with certain settings defined (MessageMetadataRegistry and Conventions). That behavior couples the transport to be used in the context of an NServiceBus endpoint, and makes the raw transport usage more complex. E.g., the following hacks are required:
It would be good to decouple the transport from the SerializationDefinition concept and use the same approach used to define the message unwrapper, which is just a Func<,>:
Transport currently relies on the serializer defined in the EndpointConfiguration or a custom serializer configured to handle message wrapping before sends. The problem is that the serializer is defined using the
SerializationDefinition
Core type, which, in order to be used, requires an Endpoint with certain settings defined (MessageMetadataRegistry
andConventions
). That behavior couples the transport to be used in the context of an NServiceBus endpoint, and makes the raw transport usage more complex. E.g., the following hacks are required:NServiceBus.AzureStorageQueues/src/Transport/AzureStorageQueueTransport.cs
Lines 131 to 145 in 35e4cb2
NServiceBus.AzureStorageQueues/src/Transport/AzureStorageQueueTransport.cs
Lines 237 to 260 in 35e4cb2
It would be good to decouple the transport from the
SerializationDefinition
concept and use the same approach used to define the message unwrapper, which is just aFunc<,>
:NServiceBus.AzureStorageQueues/src/Transport/AzureStorageQueueTransport.cs
Lines 433 to 441 in 35e4cb2
It's important to keep in mind wire compatibility for in-flight messages.
The text was updated successfully, but these errors were encountered: