Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptBuilder has code for DateTime/DateTimeOffset as correlation property, but that's unsupported by Core #1148

Open
DavidBoike opened this issue Feb 14, 2023 · 0 comments

Comments

@DavidBoike
Copy link
Member

The ScriptBuilder project contains code paths to deal with CorrelationPropertyType values of DateTime and DateTimeOffset (and these are also documented here, via an include here) even though NServiceBus limits correlation property types to string, Guid, long, ulong, int, uint, short, ushort, as a runtime check and raised to a compile-level check with a Roslyn analyzer.

That is, in a word, weird. Especially since the runtime type checks have been around since NServiceBus 6.0.0, and SQL Persistence did not exist prior to NServiceBus 6.

This should be investigated, unusable code paths should be removed to simplify things, and documentation should be updated to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant