Update docs on MSMQ bridge specifics #6812
Conversation
| @@ -196,9 +196,9 @@ public void QueueName() | |||
| #region custom-address | |||
|
|
|||
| var transport = new BridgeTransport(new MsmqTransport()); | |||
| transport.HasEndpoint("Finance", "finance_queue_name"); | |||
| transport.HasEndpoint("Finance", "finance@machinename"); | |||
There was a problem hiding this comment.
I wonder if we should keep both examples:
- Where the endpoint is on a different machine => finance@machinename
- Where the queue name is different due to https://docs.particular.net/nservicebus/endpoints/specify-endpoint-name#input-queue being used? => finance_queue_name
There was a problem hiding this comment.
And perhaps spell out that 1 is MSMQ specific and that 2 applies to all transports?
There was a problem hiding this comment.
Where the queue name is different due to https://docs.particular.net/nservicebus/endpoints/specify-endpoint-name#input-queue being used? => finance_queue_name
I've realized that my statement here is wrong, the address override should only be used to control where messages get dispatched to and where subscription messages are sent.
To control the name of the queue that the bridge reads from the endpoint name has to be adjusted since that is what we pass into the raw endpoint that does the reading.
In short: The text in this PR is ok even though I'm not sure if "machinename" is better than "another-machine"
There was a problem hiding this comment.
I thought perhaps this PR is no longer relevant since we fixed it so that you can specify the machine name in the queue address, and we decided that just specifying a queue name isn't really supported?
There was a problem hiding this comment.
Got it, so we can close this PR
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Update the documentation to:
@machinein the QueueAddress