Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra effects called by hurtEnemy not happening when swung with offhand #7

Open
Partonetrain opened this issue Apr 21, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@Partonetrain
Copy link
Owner

Partonetrain commented Apr 21, 2024

image

Similar issue with Mjolnir and Thundercaller

@Partonetrain Partonetrain changed the title Slaughtersaw dealing default damage in offhand Extra effects called by hurtEnemy not happening when swung with offhand Apr 21, 2024
@Partonetrain Partonetrain added the wontfix This will not be worked on label Aug 25, 2024
@Partonetrain
Copy link
Owner Author

hurtEnemy is an overriden vanilla method and obviously does not consider attack hand. There might be other ways to implement extra effects on the offhand, but IMO it would fall more on BetterCombat to provide a solution to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant