Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrypt prepends $s0 #64

Closed
firaja opened this issue Jun 16, 2022 · 2 comments
Closed

Scrypt prepends $s0 #64

firaja opened this issue Jun 16, 2022 · 2 comments
Assignees
@firaja
Labels
priority: high status: needs information type: bug Something isn't working
Milestone
1.6.0

Comments

@firaja
Copy link
Member

firaja commented Jun 16, 2022

Describe the bug
The ScryptFunction#hash generates a correct output but appends a $s0. It might be a blunder while coding...
To be checked where it came from (maybe some wrong specifications).

To Reproduce
Just hash anything with scrypt

Expected behavior
No $s0 should be prepended

Environment:

  • Any

Additional context
@firaja firaja self-assigned this Jun 16, 2022
@firaja firaja added this to the 1.6.0 milestone Jun 16, 2022
firaja added a commit that referenced this issue Jun 17, 2022
@firaja
#64: removed from scrypt output
11c9220
@firaja firaja closed this as completed Jun 17, 2022
@firaja
Copy link
Member Author

firaja commented Jun 17, 2022

Solved in #64

@dpatriarche dpatriarche mentioned this issue Aug 10, 2022
Closed
@dpatriarche
Copy link

Ref #66 -- The $s0 prefix is added by the lambdaworks scrypt library's SCryptUtil.scrypt() function (from package: "com.lambdaworks:scrypt:1.4.0"). This is non-standard behavior; other libraries that generate scrypt hash strings do not include the $s0 prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firaja firaja

Labels
priority: high status: needs information type: bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@dpatriarche @firaja