Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQ] SHA256 of geohashes in the intersection code #807

Open
tremblerz opened this issue May 12, 2020 · 4 comments
Open

[FEATURE-REQ] SHA256 of geohashes in the intersection code #807

tremblerz opened this issue May 12, 2020 · 4 comments
Assignees
Labels
Enhancement Enhancing an existing feature or a request In Progress - Check Jira

Comments

@tremblerz
Copy link
Contributor

Issue type

This builds on top of #806. This is going to be a change that we need to apply to the intersect logic. See the old PR for reference - relevant file diff from the PR
When we load the location data from the Asyncstorage, instead of reading the raw data, we need to read from Geohashes. The next step is as follows -

  1. read geohashes
  2. Append timestamp to the geohash
  3. Apply SHA256([geohash, timestamp])
  4. Compare it with the received points in the intersect.js
@diarmidmackenzie
Copy link

My view is that these should use a slow hash algorithm, and scrypt is my favoured approach for various reasons detailed here:

https://pathcheck.atlassian.net/wiki/spaces/TEST/pages/61112371/Design+for+MVP1+HA+JSON+Changes

@summetj summetj added the Enhancement Enhancing an existing feature or a request label May 13, 2020
@summetj
Copy link
Collaborator

summetj commented May 13, 2020

@tremblerz - If I'm reading your issue description correctly, #806 is the first step in this process that can be done independently, and this can be added only after #806 is finished. Did I understand that correctly?

@diarmidmackenzie
Copy link

For anyone who wants to work on tis please see Jira SAF-268 for a proposed alternate plan of attack.

Same basic outcome, but proposing different sequencing to ensure Safe Paths & Safe Places retain compatibility as much as possible during this change.

@yonatanmk
Copy link
Collaborator

To clarify, we're going to hash the concatenation of the geohash and timestamp using Scrypt, not SHA256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancing an existing feature or a request In Progress - Check Jira
Projects
None yet
Development

No branches or pull requests

5 participants