Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Center Bundles in multiplayer had incorrect amount of items and broken names on Non-English language #795

Closed
AppleNorris opened this issue Aug 2, 2021 · 4 comments
Assignees
Labels
bug This is an unintended error or behavior that can be addressed with specific development changes.
Milestone

Comments

@AppleNorris
Copy link

AppleNorris commented Aug 2, 2021

Describe the bug
Bundle-breaking bug that appears to be happening on Non-English languages.
In my case happened in multiplayer.
Bundle names are breaking and appearing as "Узелок 1" (Bundle 1), "Узелок 2" (Bundle 2), "Узелок 3" (Bundle 3), and so on.
Bundle table is breaking and shows incorrect amount of items that are needed for the bundles.
There is a possibility that this bug happens to be the same as #765, but this time it happens in multiplayer.

SV Forum Thread - it seems that Portuguese players have the same issue in multiplayer.
SV Forum Thread - it's the same bug as in April.

To Reproduce

  1. Start both client and server on Russian.
  2. Create a new save in multiplayer.
  3. Play for some time (in my case this bug happened three times - on Summer 28, Fall 11, Fall 15) while getting bundles done.
  4. It will break, just give it time.

Command "regenerate_bundles" does reset all bundles, but they broke in a few days anyway.

Environment server: Windows 10 21H1, Steam, Stardew Valley 1.5.4, SMAPI 3.12.0.
Environment client: Windows 7 (all latest updates), Steam, Stardew Valley 1.5.4, SMAPI 3.12.0.
Both server and client are using similar modlists that are shown in the log below.

Log file
Updated:
https://smapi.io/log/c8cf67946d3142dbbea0ae1819447440 - my log.
https://smapi.io/log/48fc4dbc71df4f458b0c4e6c8e431a48 - friend's log.

Screenshots
svb1
svb7
svb6
svb5
svb4
svb3
svb2

All other bundles are finished and I can't see them, but I presume that they do have the same issue.

@AppleNorris
Copy link
Author

AppleNorris commented Aug 2, 2021

Tested it a bit - doesn't seem like this is something that has to do with cutscenes (that are tied to the ones with junimos) or bundles themselves (tried to fill bundles one by one - hadn't experienced any bugs).
I think it has something to do with the Witch cutscene? At least it's the only cutscene that happened before the first case - or maybe it has something to do with the black egg (though we had a bit more than 3 eggs... still it might be a good lead) - or it doesn't matter at all.

Added:
Tried savefile from 'halfqheart'. It seems that we have a few things in common - Skull Key, Dwarvish Translation Guide, cat, mushroom cave, chicken coop, lvl2 house.

@Kostyansa
Copy link

Kostyansa commented Aug 14, 2021

Same problem, same language, but SMAPI is version 3.11.0
And i think with AppleNorris we have only UI Info Suite 2.0.0 in common from mod list.
Broken bundles:
image
image
Log:
https://smapi.io/log/ec16cab77a7748d892cdddf3218ae7c8
Save file with broken bundles:
Star_287512165.zip

@Pathoschild Pathoschild added the bug This is an unintended error or behavior that can be addressed with specific development changes. label Aug 17, 2021
@Pathoschild Pathoschild added this to the 3.14.0 milestone Aug 17, 2021
@AppleNorris
Copy link
Author

AppleNorris commented Aug 23, 2021

I have found that this bug always duplicates last "/ {NUMBER}" before "</ string>" and that it can possibly lead to savefile bloating - had to manually clean about 300kb of the duplicate numbers after one in-game year, even after finishing all bundles.

@Pathoschild Pathoschild self-assigned this Sep 5, 2021
@Pathoschild Pathoschild modified the milestones: 3.14.0, 3.12.6 Sep 5, 2021
@Pathoschild
Copy link
Owner

SMAPI 3.12.6 no longer updates in-game bundles to reflect mod changes to the bundle data, so the bundle corruption should no longer happen. See #805 for a related issue that still happens in 3.12.6+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an unintended error or behavior that can be addressed with specific development changes.
Projects
None yet
Development

No branches or pull requests

3 participants