From 5e395f5823fdaebb0b25d0af120165b5b386b909 Mon Sep 17 00:00:00 2001
From: Quietust <quietust@gmail.com>
Date: Sun, 22 Oct 2017 18:20:32 -0600
Subject: [PATCH] Add comments to unknown fields, based on known meanings in
 old versions

---
 df.entities.xml | 156 +++++++++++++++---------------------------------
 1 file changed, 48 insertions(+), 108 deletions(-)

diff --git a/df.entities.xml b/df.entities.xml
index 19aa727c3..9d23b51d3 100644
--- a/df.entities.xml
+++ b/df.entities.xml
@@ -105,12 +105,12 @@
         <static-array name='unit_counts' type-name='int16_t' count='152' index-enum='profession'/>
         <int16_t name='population'/>
         <int16_t/>
-        <int16_t/>
-        <int16_t/>
+        <int16_t comment='in 0.23, omnivores'/>
+        <int16_t comment='in 0.23, carnivores'/>
         <int16_t name='trained_animals'/>
         <int16_t name='other_animals'/>
-        <int16_t/>
-        <int32_t/>
+        <int16_t comment='in 0.23, potential soldiers'/>
+        <int32_t comment='in 0.23, combat aptitude'/>
         <static-array name='item_counts' type-name='int32_t' count='112' index-enum='item_type'/>
         <stl-vector name='created_weapons' type-name='int32_t' index-refers-to='$global.world.raws.itemdefs.weapons[$]'/>
         <compound name='wealth'>
@@ -138,7 +138,7 @@
         <int32_t name='total_insanities'/>
         <int32_t name='total_executions'/>
         <int32_t name='num_artifacts'/>
-        <int32_t/>
+        <int32_t comment='in 0.23, total siegers'/>
         <stl-vector name='discovered_creature_foods' type-name='bool' index-refers-to='(find-creature $)'/>
         <stl-vector name='discovered_creatures' type-name='bool' index-refers-to='(find-creature $)'/>
         <stl-vector name='discovered_plant_foods' type-name='bool' index-refers-to='(find-plant-raw $)'/>
@@ -470,15 +470,15 @@
             <stl-vector name='meat_fish_recipes' pointer-type='entity_recipe'/>
             <stl-vector name='other_recipes' pointer-type='entity_recipe'/>
 
-            <static-array name='unk13' count='3'>
+            <static-array name='unk13' count='3' comment='in 0.23, these were material/matgloss pairs, never used for anything'>
                 <int16_t name='unk1' init-value='-1'/>
                 <int32_t name='unk2'/>
             </static-array>
 
-            <stl-vector name='unk14' pointer-type='item'/>
+            <stl-vector name='unk14' pointer-type='item' comment='in 0.23, items that would be equipped by the arriving King, never used'/>
 
-            <int16_t name='unk15a'/>
-            <int16_t name='unk15b'/>
+            <int16_t name='unk15a' comment='in 0.23, minimum temperature'/>
+            <int16_t name='unk15b' comment='in 0.23, maximum temperature'/>
 
             <static-array name='ethic' count='22' index-enum='ethic_type'>
                 <enum base-type='int16_t' type-name='ethic_response'/>
@@ -604,15 +604,15 @@
         <pointer name='activity_stats' type-name='entity_activity_statistics'/>
 
         <compound name='unknown1e'>
-            <int16_t name='unk47'/>
-            <int32_t name='unk48'/>
-
-            <int32_t name='unk49a'/>
-            <int32_t name='unk49b'/>
-            <int32_t name='unk49c'/>
-            <static-array name='unk49d' count='10' type-name='int32_t'/>
-            <int32_t name='unk49e'/>
-            <int32_t name='unk49f'/>
+            <int16_t name='unk47' comment='in 0.23, last communicate season'/>
+            <int32_t name='unk48' comment='in 0.23, last communicate year'/>
+
+            <int32_t name='unk49a' comment='in 0.23, imports'/>
+            <int32_t name='unk49b' comment='in 0.23, exports'/>
+            <int32_t name='unk49c' comment='in 0.23, recent offerings'/>
+            <static-array name='unk49d' count='10' type-name='int32_t' comment='in 0.23, offerings history'/>
+            <int32_t name='unk49e' comment='in 0.23, hostility level - determined siege size, had a chance to reset to 1'/>
+            <int32_t name='unk49f' comment='in 0.23, determined siege size'/>
             <int32_t since='v0.40.01'/>
         </compound>
 
@@ -625,96 +625,36 @@
             <compound name='mill_cookable' type-name='material_vec_ref'/>
             <compound name='mill_dye' type-name='material_vec_ref'/>
 
-            <stl-vector name='armor_leather'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='armor_chain'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='armor_plate'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='armor_under'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='armor_over'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='armor_cover'>
-                <int16_t ref-target='itemdef_armorst'/>
-            </stl-vector>
-            <stl-vector name='pants_leather'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='pants_chain'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='pants_plate'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='pants_under'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='pants_over'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='pants_cover'>
-                <int16_t ref-target='itemdef_pantsst'/>
-            </stl-vector>
-            <stl-vector name='helm_leather'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='helm_chain'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='helm_plate'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='helm_under'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='helm_over'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='helm_cover'>
-                <int16_t ref-target='itemdef_helmst'/>
-            </stl-vector>
-            <stl-vector name='shoes_leather'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='shoes_chain'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='shoes_plate'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='shoes_under'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='shoes_over'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='shoes_cover'>
-                <int16_t ref-target='itemdef_shoesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_leather'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_chain'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_plate'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_under'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_over'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
-            <stl-vector name='gloves_cover'>
-                <int16_t ref-target='itemdef_glovesst'/>
-            </stl-vector>
+            <stl-vector name='armor_leather' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='armor_chain' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='armor_plate' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='armor_under' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='armor_over' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='armor_cover' type-name='int16_t' ref-target='itemdef_armorst'/>
+            <stl-vector name='pants_leather' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='pants_chain' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='pants_plate' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='pants_under' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='pants_over' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='pants_cover' type-name='int16_t' ref-target='itemdef_pantsst'/>
+            <stl-vector name='helm_leather' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='helm_chain' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='helm_plate' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='helm_under' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='helm_over' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='helm_cover' type-name='int16_t' ref-target='itemdef_helmst'/>
+            <stl-vector name='shoes_leather' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='shoes_chain' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='shoes_plate' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='shoes_under' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='shoes_over' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='shoes_cover' type-name='int16_t' ref-target='itemdef_shoesst'/>
+            <stl-vector name='gloves_leather' type-name='int16_t' ref-target='itemdef_glovesst'/>
+            <stl-vector name='gloves_chain' type-name='int16_t' ref-target='itemdef_glovesst'/>
+            <stl-vector name='gloves_plate' type-name='int16_t' ref-target='itemdef_glovesst'/>
+            <stl-vector name='gloves_under' type-name='int16_t' ref-target='itemdef_glovesst'/>
+            <stl-vector name='gloves_over' type-name='int16_t' ref-target='itemdef_glovesst'/>
+            <stl-vector name='gloves_cover' type-name='int16_t' ref-target='itemdef_glovesst'/>
         </compound>
         <static-array name='assignments_by_type' count='25'
                       index-enum='entity_position_responsibility'>