From 050d0016fb0031157f8f8470a5ec5bb89ea9c98d Mon Sep 17 00:00:00 2001
From: Paul Woitaschek <woitaschek@posteo.de>
Date: Sat, 5 Jan 2019 22:53:52 +0100
Subject: [PATCH] Removed the obsolete detekt rules.

---
 app/detekt.yml                                | 203 ------------------
 .../bookOverview/BookOverviewController.kt    |   1 -
 2 files changed, 204 deletions(-)
 delete mode 100644 app/detekt.yml

diff --git a/app/detekt.yml b/app/detekt.yml
deleted file mode 100644
index b5ef9b1f62..0000000000
--- a/app/detekt.yml
+++ /dev/null
@@ -1,203 +0,0 @@
-autoCorrect: true
-failFast: false
-
-build:
-  warningThreshold: 5
-  failThreshold: 10
-  weights:
-    complexity: 2
-    formatting: 1
-    LongParameterList: 1
-    comments: 1
-
-processors:
-  active: true
-  exclude:
-  # - 'FunctionCountProcessor'
-  # - 'PropertyCountProcessor'
-  # - 'ClassCountProcessor'
-  # - 'PackageCountProcessor'
-  # - 'KtFileCountProcessor'
-
-console-reports:
-  active: true
-  exclude:
-  #  - 'ProjectStatisticsReport'
-  #  - 'ComplexityReport'
-  #  - 'NotificationReport'
-  #  - 'FindingsReport'
-  #  - 'BuildFailureReport'
-
-output-reports:
-  active: true
-  exclude:
-  #  - 'PlainOutputReport'
-  #  - 'XmlOutputReport'
-
-potential-bugs:
-  active: true
-  DuplicateCaseInWhenExpression:
-    active: true
-  EqualsWithHashCodeExist:
-    active: true
-  ExplicitGarbageCollectionCall:
-    active: true
-  UnreachableCode:
-    active: true
-  LateinitUsage:
-    active: false
-  UnsafeCallOnNullableType:
-    active: false
-  UnsafeCast:
-    active: false
-
-performance:
-  active: true
-  ForEachOnRange:
-    active: true
-  SpreadOperator:
-    active: true
-  UnnecessaryTemporaryInstantiation:
-    active: true
-
-exceptions:
-  active: true
-
-empty-blocks:
-  active: true
-
-complexity:
-  active: true
-  LongMethod:
-    threshold: 20
-  LongParameterList:
-    threshold: 5
-  LargeClass:
-    threshold: 150
-  ComplexMethod:
-    threshold: 10
-  TooManyFunctions:
-    threshold: 10
-  ComplexCondition:
-    threshold: 3
-  LabeledExpression:
-    active: false
-
-code-smell:
-  active: true
-  FeatureEnvy:
-    threshold: 0.5
-    weight: 0.45
-    base: 0.5
-
-formatting:
-  active: true
-  useTabs: true
-  Indentation:
-    active: true
-    indentSize: 2
-  ConsecutiveBlankLines:
-    active: true
-    autoCorrect: true
-  MultipleSpaces:
-    active: true
-    autoCorrect: true
-  SpacingAfterComma:
-    active: true
-    autoCorrect: true
-  SpacingAfterKeyword:
-    active: true
-    autoCorrect: true
-  SpacingAroundColon:
-    active: true
-    autoCorrect: true
-  SpacingAroundCurlyBraces:
-    active: true
-    autoCorrect: true
-  SpacingAroundOperator:
-    active: true
-    autoCorrect: true
-  TrailingSpaces:
-    active: true
-    autoCorrect: true
-  UnusedImports:
-    active: true
-    autoCorrect: true
-  OptionalSemicolon:
-    active: true
-    autoCorrect: true
-  OptionalUnit:
-    active: true
-    autoCorrect: true
-  ExpressionBodySyntax:
-    active: false
-    autoCorrect: false
-  ExpressionBodySyntaxLineBreaks:
-    active: false
-    autoCorrect: false
-  OptionalReturnKeyword:
-    active: true
-    autoCorrect: false
-
-style:
-  active: true
-  ReturnCount:
-    active: true
-    max: 2
-  NewLineAtEndOfFile:
-    active: true
-  OptionalAbstractKeyword:
-    active: true
-  ForbiddenComment:
-    active: true
-    values: 'TODO:,FIXME:,STOPSHIP:'
-  ForbiddenImport:
-    active: false
-    imports: ''
-  ModifierOrder:
-    active: true
-  MagicNumber:
-    active: true
-    ignoreNumbers: '-1,0,1,2'
-    ignoreHashCodeFunction: false
-    ignorePropertyDeclaration: false
-    ignoreAnnotation: false
-  WildcardImport:
-    active: true
-  SafeCast:
-    active: true
-  MaxLineLength:
-    active: true
-    maxLineLength: 120
-    excludePackageStatements: false
-    excludeImportStatements: false
-  NamingConventionViolation:
-    active: true
-    variablePattern: '^(_)?[a-z$][a-zA-Z$0-9]*$'
-    constantPattern: '^([A-Z_]*|serialVersionUID)$'
-    methodPattern: '^[a-z$][a-zA-Z$0-9]*$'
-    classPattern: '[A-Z$][a-zA-Z$]*'
-    enumEntryPattern: '^[A-Z$][a-zA-Z_$]*$'
-
-comments:
-  active: true
-  CommentOverPrivateMethod:
-    active: true
-  CommentOverPrivateProperty:
-    active: true
-  UndocumentedPublicClass:
-    active: false
-    searchInNestedClass: true
-    searchInInnerClass: true
-    searchInInnerInterface: true
-  UndocumentedPublicFunction:
-    active: false
-
-# *experimental feature*
-# Migration rules can be defined in the same config file or a new one
-migration:
-  active: true
-  imports:
-    # your.package.Class: new.package.or.Class
-    # for example:
-    # io.gitlab.arturbosch.detekt.api.Rule: io.gitlab.arturbosch.detekt.rule.Rule
diff --git a/app/src/main/java/de/ph1b/audiobook/features/bookOverview/BookOverviewController.kt b/app/src/main/java/de/ph1b/audiobook/features/bookOverview/BookOverviewController.kt
index 85bedfaaca..0282556fc4 100644
--- a/app/src/main/java/de/ph1b/audiobook/features/bookOverview/BookOverviewController.kt
+++ b/app/src/main/java/de/ph1b/audiobook/features/bookOverview/BookOverviewController.kt
@@ -186,7 +186,6 @@ class BookOverviewController : BaseController(),
         showPlaying(state.playing)
 
         useGrid = state.useGrid
-        //columnCount = state.columnCount
         val lm = recyclerView.layoutManager as GridLayoutManager
         lm.spanCount = state.columnCount
         gridMenuItem.item.apply {