-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SQLite (updated description) also some file restructuring #24
Comments
I think it will be better to split logics of each db separately. This could help when adding more features and also when adding additional databases. |
@ArthureVarghese Hey thanks for the suggestion. This is a good idea. Probably creating a file for each database which will then be called by the core.py ex: mysql.py, postgres.py, mariadb.py. I am planning to make a new release tomorrow or monday, then we can restructure. If you want to try feel free, otherwise I will do it |
Yeah sure. I'll try. Thank You |
@evangelosmeklis Should I do this after next release or start from now? |
@ArthureVarghese Just start now if you want. I will do the release and you can pull the changes and fix any conflicts. I think there will not be many. |
@evangelosmeklis I have a basic version of the changes. Should i submit a PR? I have some more ideas/suggestions to improve them. |
@ArthureVarghese yes please do submit it! Make sure you run the unittests before making the pr and also if you have added new stuff create a unittest for them. For new features discussion please open an issue with label feature 😁 |
I will continue this and start by adding SQLite support this week |
This should be added to release 0.1.4 (after 0.1.3 is released)
The text was updated successfully, but these errors were encountered: