Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SQLite (updated description) also some file restructuring #24

Closed
evangelosmeklis opened this issue Sep 13, 2024 · 8 comments · Fixed by #49
Closed

Support for SQLite (updated description) also some file restructuring #24

evangelosmeklis opened this issue Sep 13, 2024 · 8 comments · Fixed by #49
Assignees
Labels
feature A big implementation good first issue Good for newcomers

Comments

@evangelosmeklis
Copy link
Owner

This should be added to release 0.1.4 (after 0.1.3 is released)

@evangelosmeklis evangelosmeklis added good first issue Good for newcomers feature A big implementation labels Sep 13, 2024
@ArthureVarghese
Copy link
Contributor

I think it will be better to split logics of each db separately. This could help when adding more features and also when adding additional databases.

@evangelosmeklis
Copy link
Owner Author

@ArthureVarghese Hey thanks for the suggestion. This is a good idea. Probably creating a file for each database which will then be called by the core.py ex: mysql.py, postgres.py, mariadb.py. I am planning to make a new release tomorrow or monday, then we can restructure. If you want to try feel free, otherwise I will do it

@ArthureVarghese
Copy link
Contributor

Yeah sure. I'll try. Thank You

@ArthureVarghese
Copy link
Contributor

@evangelosmeklis Should I do this after next release or start from now?

@evangelosmeklis
Copy link
Owner Author

@ArthureVarghese Just start now if you want. I will do the release and you can pull the changes and fix any conflicts. I think there will not be many.

@ArthureVarghese
Copy link
Contributor

@evangelosmeklis I have a basic version of the changes. Should i submit a PR? I have some more ideas/suggestions to improve them.

@evangelosmeklis
Copy link
Owner Author

@ArthureVarghese yes please do submit it! Make sure you run the unittests before making the pr and also if you have added new stuff create a unittest for them. For new features discussion please open an issue with label feature 😁

@evangelosmeklis evangelosmeklis self-assigned this Sep 23, 2024
@evangelosmeklis
Copy link
Owner Author

I will continue this and start by adding SQLite support this week

@evangelosmeklis evangelosmeklis changed the title Support for Additional Databases (e.g., SQLite, Oracle, SQL Server) Support for SQLite (updated description) also some file restructuring Sep 25, 2024
@evangelosmeklis evangelosmeklis linked a pull request Sep 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A big implementation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants