Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.json sidecars mismatched #61

Open
zenkavi opened this issue Jul 30, 2021 · 0 comments · May be fixed by fcbg-md/BIDSonym#1
Open

.json sidecars mismatched #61

zenkavi opened this issue Jul 30, 2021 · 0 comments · May be fixed by fcbg-md/BIDSonym#1
Assignees
Labels
bug Something isn't working

Comments

@zenkavi
Copy link
Contributor

zenkavi commented Jul 30, 2021

Hi,

I didn't entirely nail down how this happens but when using the del_meta options .json sidercars can get mismatched when writing them back to the original bids directory.

In my case my bold json's were confused with sbref jsons, sbref jsons with physio ones etc.

It might be because when the file names are 'zip' ped together some files aren't correctly aligned.
https://github.com/PeerHerholz/BIDSonym/blob/master/bidsonym/utils.py#L199

Sorry I don't have more time to write a more detailed report but just wanted to flag this in case others have come across too. If defacing after preprocessing this could be easy to miss because the dataset would still pass validator but no bids app's would rely on info in sidecars anymore (e.g. fmriprep).

@zenkavi zenkavi added the bug Something isn't working label Jul 30, 2021
@vferat vferat linked a pull request Jun 19, 2023 that will close this issue
PeerHerholz added a commit that referenced this issue Oct 24, 2023
This should fix #72, #69 and parts of #64 and #61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants