Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing same named files #1690

Open
turetske opened this issue Oct 28, 2024 · 0 comments
Open

Syncing same named files #1690

turetske opened this issue Oct 28, 2024 · 0 comments
Assignees
Labels
client Issue affecting the OSDF client enhancement New feature or request
Milestone

Comments

@turetske
Copy link
Collaborator

Currently, to avoid the case where two files have the same name and are synced but happen to have different contents can cause the synced file to become an amalgam of the two, the code will overwrite the file entirely during a sync if it's determined to be smaller than the original. We want to be smarter than this:

  1. If the files are of differing sizes at ALL (larger or smaller), we should rewrite the file except in case 2)
  2. As per the discussion in Sync and Recursive results #1638 - For internal uses of recursive sync (such as the plugin or on retries), we are okay if the transfer request restarts midway as there is no worry about collision of same named files with different contents
@turetske turetske self-assigned this Oct 28, 2024
@turetske turetske added enhancement New feature or request client Issue affecting the OSDF client labels Oct 28, 2024
@turetske turetske added this to the v7.14 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issue affecting the OSDF client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant