Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of trailing / in federation prefixes #1806

Open
jhiemstrawisc opened this issue Dec 6, 2024 · 0 comments
Open

Better handling of trailing / in federation prefixes #1806

jhiemstrawisc opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
internal Internal code improvements, not user-facing registry Issue relating to the registry component
Milestone

Comments

@jhiemstrawisc
Copy link
Member

A user tried registering a namespace like /foo/bar/, which generated an error. The correct registration was /foo/bar without a trailing /.

I do think it's important that our internal representations of prefixes contain a trailing / so that it's much harder to accidentally match /foo/barbaz to /foo/bar, but we can make this logic transparent to users by permitting registration of both /foo/bar and /foo/bar/ (and treating them the same under the hood).

@jhiemstrawisc jhiemstrawisc added internal Internal code improvements, not user-facing registry Issue relating to the registry component labels Dec 6, 2024
@jhiemstrawisc jhiemstrawisc added this to the v7.13.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal code improvements, not user-facing registry Issue relating to the registry component
Projects
None yet
Development

No branches or pull requests

2 participants