Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated error message in cache's self-check feature #1808

Open
jhiemstrawisc opened this issue Dec 6, 2024 · 0 comments
Open

Truncated error message in cache's self-check feature #1808

jhiemstrawisc opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working cache Issue relating to the cache component error messages Improvements to error messages test Improvements to the test suite
Milestone

Comments

@jhiemstrawisc
Copy link
Member

We've observed unintended error message truncation in this function. The error message printed out wasself-test failed during download. File is cleaned up at without the file URL.

Let's make sure this truncation can't happen by making sure fileUrl can't be the empty. This probably also indicates there was an uncaught error in generateTestFile().

On that note -- change all the references from "files" to "objects". Eventually we'll be able to back caches with non-posix object stores.

@jhiemstrawisc jhiemstrawisc added bug Something isn't working test Improvements to the test suite cache Issue relating to the cache component error messages Improvements to error messages labels Dec 6, 2024
@jhiemstrawisc jhiemstrawisc added this to the v7.13.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cache Issue relating to the cache component error messages Improvements to error messages test Improvements to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants