InitConfigDir is not platform agnostic

[turetske]

In the case where the $HOME or configDir directory isn't set, InitConfigDir makes an assumption that it's running on Linux.

This is rare case that could occur on Windows, but hasn't yet, so is probably why it hasn't been caught.

The InitConfigDir should be made platform agnostic and the tests should be allowed to run on windows to ensure everything works. We may need a discussion on what fall back config directory should be when not on Linux (as the code uses "/etc/pelican", which is a Linux path).

Basically, we want to ensure that for pelican clients running on either windows or linux, if the ConfigDir isn't set and the user isn't root, we have a fallback location that the client attempts to use on both.

[bbockelm]

@turetske - can you drop links into where the code makes these assumptions?

In general, the CI tests are indeed run on Windows -- are there specific ones that are currently marked as Linux-only that should be extended to Windows as well? If so, can you drop links so one can easily pick up the ticket?

[turetske]

@bbockelm Ah.

So we didn't have CI tests testing this function with this specific case (What happens if "ConfigDir" isn't set)

I found this problem when writing these specific tests which then failed on windows.

The location this occurs is here

This code in this function was originally part of InitServer so the linux specifics were fine, then. When it became its own function that was used by the general InitConfig is when this was introduced, because this wasn't changed.

This ticket should be complete with #1836 which identifies the larger problem with how we structured this code.