Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]-Consider different solutions for language localization support #1064

Open
jtalborough opened this issue Feb 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jtalborough
Copy link
Contributor

Additional context
Per a chat and request from @ediablo80 & @TrevorPayne it would be great to add better support for multiple languages similar to other private solutions we have including the l18n module.

this issue is opened as a flag and to further the discussion.

One concept that came up was the possibility of using variables in the config that can be filled at runtime with the language support device.

@jtalborough jtalborough added the enhancement New feature or request label Feb 8, 2023
@TrevorPayne
Copy link
Contributor

I'm not certain that we really need to do anything to this other than perhaps integrate the I18N plugin into base essentials.

All it's doing is loading up a JSON (or several), firing an event as the language changes, and allowing an interface for other classes to grab data, by key, from the JObject loaded from the language file.

I think adding this to base essentials and providing some more explicit documentation for how to implement it in code would go a long way to alleviating the perceived deficiency in this code. I can say from experience that it works very well in it's current state. It just requires a bit of tribal knowledge to access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants