Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide App::perlimports to the image #60

Open
bschmalhofer opened this issue Mar 19, 2024 · 3 comments
Open

Provide App::perlimports to the image #60

bschmalhofer opened this issue Mar 19, 2024 · 3 comments

Comments

@bschmalhofer
Copy link

bschmalhofer commented Mar 19, 2024

Hi,

I am fond of perlimports for cleaning up my import statements. Would it make sense to add that module to the image? The list of dependencies looks a bit daunting though.

Edit: The issue with DBD::ODBC was unrelated.

@atoomic
Copy link
Member

atoomic commented Mar 19, 2024

I see no objections to add it, but also note that you can add extra packages using a cpanfile with cpm or cpanm actions

Note: there is one example described here https://github.com/Perl/docker-perl-tester?tab=readme-ov-file#using-the-images-with-github-workflow
and the two actions are documented there:

@oalders
Copy link
Collaborator

oalders commented Mar 19, 2024

I am fond of perlimports for cleaning up my import statements

❤️

We could add it for perl >= '5.18.0'. It would pull in a lot of dependencies, but I'm not sure how bad that would be, considering how many dependencies these builds already contain.

@bschmalhofer
Copy link
Author

I see no objections to add it, but also note that you can add extra packages using a cpanfile with cpm or cpanm actions

Yes, that is what I do in https://github.com/RotherOSS/otobo/blob/5c899d77c7d9e33b9471ca26fcbfbc60a9ed68d1/.github/workflows/code_policy.yml#L60 .
This works fine, so adding App::perlimports would be just for convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants