-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement :alpine
variant
#24
base: master
Are you sure you want to change the base?
Conversation
2a416b5
to
5eaef5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured I'd leave a few notes on this, both to try to help out and as a subtle bump. 😏 ❤️
I would also like an Alpine variant, but probably the way to go would be to change everything from the ground up, including Releases.yaml and generate.pl |
Replacing |
Thanks, could you elaborate further? I did a cursory check on Another thing to consider is that |
The @docker-library-bot can trigger an |
Yeah, that's what I gathered on reading the Thanks for bringing this up anyway; I might get around to this soon as I'll be getting more involved with Perl RC builds and perhaps this might provide some additional way for managing/bring these up. |
`cpanm` can make use of `make` when installing pure-Perl stuff.
By installing `make` together with build deps we avoid downloading the apkindex more than once. We make it stay by adding it as a runtime dep before deleting build deps.
Apply review changes and make this closer to what we have in the mainline Dockerfiles, thanks to @tianon! Update this to build Perl 5.32 now; it seems to build and test fine without any modification!
5eaef5a
to
26d57bb
Compare
We previously had `PERL_CPANM_OPT=--no-wget`, but since that can be a user-set variable in child images, let's just install the real wget instead (especially since the busybox builtin isn't as feature-rich.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw some activity so I figured I'd re-review 😅 ❤️
The previous commit that pulls in dpkg also pulls the perl packaged for alpine, which adds some 40MB to the resulting image, so ensure we filter that out when generating the runtime deps.
This would still be great! |
Is there something this is stalled on? I would love to help if possible |
work-in-progress PR to fix #23
setlocale()
to work around test failures (mainly due to musl-libc's nascent locales support)make
) to significantly reduce image layer sizeDockerfile.template
)