Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :alpine variant #24

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

zakame
Copy link
Member

@zakame zakame commented Apr 22, 2016

work-in-progress PR to fix #23

  • figure out to build without setlocale() to work around test failures (mainly due to musl-libc's nascent locales support)
  • remove build-deps (but retain make) to significantly reduce image layer size
  • try to apply for all Perl versions (maybe via Dockerfile.template)

@zakame zakame force-pushed the feature/alpine-variant branch from 2a416b5 to 5eaef5a Compare July 29, 2017 20:38
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured I'd leave a few notes on this, both to try to help out and as a subtle bump. 😏 ❤️

alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
@JJ
Copy link

JJ commented Dec 3, 2017

I would also like an Alpine variant, but probably the way to go would be to change everything from the ground up, including Releases.yaml and generate.pl

@J0WI
Copy link
Contributor

J0WI commented Nov 16, 2018

try to apply for all Perl versions (maybe via Dockerfile.template)

Replacing generate.pl with an update.sh to integrate @docker-library-bot would be an other improvement.

@zakame
Copy link
Member Author

zakame commented Nov 16, 2018

Replacing generate.pl with an update.sh to integrate @docker-library-bot would be an other improvement.

Thanks, could you elaborate further?

I did a cursory check on update.sh from other official-image repos (namely percona, postgres, and php,) and for now I think these bring in some more complexity than I'd care to maintain; I'd be open for PRs for this however.

Another thing to consider is that generate.pl also calls Devel::PatchPerl if needed, so that should be taken into account for the conversion.

@J0WI
Copy link
Contributor

J0WI commented Nov 18, 2018

The @docker-library-bot can trigger an update.sh to update Perl and generate Dockerfiles.
Just add it to https://github.com/docker-library/oi-janky-groovy/blob/master/update.sh/vars.groovy and give @docker-library-bot commit access.

@zakame
Copy link
Member Author

zakame commented Nov 18, 2018

Yeah, that's what I gathered on reading the update.sh from other images. Might be useful for Perl RC/BLEAD_POINT images, not so much on stable releases (and we already rebuild those anyway on the Hub side when buildpack-deps gets updated.)

Thanks for bringing this up anyway; I might get around to this soon as I'll be getting more involved with Perl RC builds and perhaps this might provide some additional way for managing/bring these up.

zakame and others added 5 commits September 8, 2020 17:08
`cpanm` can make use of `make` when installing pure-Perl stuff.
By installing `make` together with build deps we avoid downloading the
apkindex more than once. We make it stay by adding it as a runtime dep
before deleting build deps.
Apply review changes and make this closer to what we have in the
mainline Dockerfiles, thanks to @tianon!

Update this to build Perl 5.32 now; it seems to build and test fine
without any modification!
@zakame zakame force-pushed the feature/alpine-variant branch from 5eaef5a to 26d57bb Compare September 8, 2020 10:33
We previously had `PERL_CPANM_OPT=--no-wget`, but since that can be a
user-set variable in child images, let's just install the real wget
instead (especially since the busybox builtin isn't as feature-rich.)
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw some activity so I figured I'd re-review 😅 ❤️

alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
The previous commit that pulls in dpkg also pulls the perl packaged for
alpine, which adds some 40MB to the resulting image, so ensure we filter
that out when generating the runtime deps.
@zakame zakame changed the title [WIP] Feature/alpine variant Implement :alpine variant Sep 11, 2020
@mohawk2
Copy link

mohawk2 commented Sep 14, 2020

This would still be great!

@rabbiveesh
Copy link

Is there something this is stalled on? I would love to help if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alpine variant
7 participants