-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBC: Blead Breaks EV #22353
Comments
This is a typemap error. I haven't bisected it, but I strongly suspect commit 2f4409b:
The typemap in EV contains this:
I.e. it deliberately uses unescaped Fixing it should be easy because the
If I understand the situation correctly, using the |
Yeah definitely.
And yes |
This seems to fix it diff --git typemap typemap
index f30badc..ea5c33b 100644
--- typemap
+++ typemap
@@ -37,9 +37,9 @@ T_LOOP
T_WATCHER
if (!(SvROK ($arg) && SvOBJECT (SvRV ($arg))
- && (SvSTASH (SvRV ($arg)) == stash_" . ($type =~ /ev_(\S+)/, "$1") . "
- || sv_derived_from ($arg, \"EV::" . ($type =~ /ev_(\S+)/, ucfirst "$1") . "\"))))
- croak (\"object is not of type EV::" . ($type =~ /ev_(\S+)/, ucfirst "$1") . "\");
+ && (SvSTASH (SvRV ($arg)) == stash_${ ($type =~ /ev_(\S+)/, \"$1") }
+ || sv_derived_from ($arg, \"EV::${ ($type =~ /ev_(\S+)/, \ucfirst "$1") }\"))))
+ croak (\"object is not of type EV::${ ($type =~ /ev_(\S+)/, \ucfirst "$1") }\");
$var = ($type)SvPVX (SvRV ($arg));
OUTPUT |
Bisecting with this invocation:
... pointed to commit 2f4409b
|
Based on some grepping there are two more modules that used this "feature", but both of them were already broken when ParseXS was made strict 12 years ago and never even had that fixed so they can be considered dead. |
On 7/1/24 13:08, Leon Timmermans wrote:
Based on some grepping there are two more modules that used this
"feature", but both of them were already broken when ParseXS was made
strict 12 years ago and never even had that fixed so they can be
considered dead.
Just for the record, those two other modules are ... ?
|
This is a bug report for perl from "Carlos Guevara" [email protected],
generated with the help of perlbug 1.43 running under perl 5.41.1.
BBC: Blead Breaks EV
Please see http://fast-matrix.cpantesters.org/?dist=EV%204.34
Flags
Perl configuration
The text was updated successfully, but these errors were encountered: