-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openssl_prefix to Configure and friends #22856
base: blead
Are you sure you want to change the base?
Conversation
I configured with blead and with your branch on each of Ubuntu Linux 24.04 LTS and OpenBSD-6.9. I then examined the content of
Is that what you would expect? |
Thanks for testing. That looks like what I'd expect. The logic I'm replicating is from the Net::SSLeay Makefile.PL here. On most unixy platforms you should be able to do |
Configure
Outdated
@@ -5356,6 +5357,21 @@ none) libs=' ';; | |||
*) libs="$ans";; | |||
esac | |||
|
|||
: see if OpenSSL is available | |||
ossl_p_c='/home/linuxbrew/.linuxbrew/opt/openssl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this start with $libpth
/$libspath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I don't really have the data to know the answer for sure, having just lifted the candidate locations straight from the Net::SSLeay Makefile.PL. But keeping it simple and using infrastructure we already have are good things to do, so maybe I'll switch to iterating through $libpth
. If it misses something weird, people can always add hints or make adjustments as needed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now starts from $libpth.
In order to add TLS to the core, we need a library, and OpenSSL is as ubiquitous as it gets. So detect where it is with logic borrowed from Net::SSLeay.
dc994d0
to
c2dc47d
Compare
In order to add TLS to the core, we need a library, and OpenSSL is as ubiquitous as it gets. So detect where it is with logic borrowed from Net::SSLeay.