Use @angular/cdk/dialog instead of custom dialog service
#269
Comments
meisekimiu
added a commit
that referenced
this issue
May 8, 2024
The current DialogService used in the web-app uses deprecated Angular functionality and a few other architectural issues. The new archive type selection component uses a modal to select a type, so this is a good opportunity to finally start migrating over to using the Angular CDK Dialog instead of our custom DialogService. Create a new service that wraps around Angular CDK's DialogService. The reason to do this right now is so that there is little confusion over which `DialogService` components are using, though in the future it would probably be best to remove this wrapper service and import the Angular CDK DialogService once we have completely deleted the old one. See #269 for more information. PER-9568: Create new component to select archive type
meisekimiu
added a commit
that referenced
this issue
May 8, 2024
The current DialogService used in the web-app uses deprecated Angular functionality and a few other architectural issues. The new archive type selection component uses a modal to select a type, so this is a good opportunity to finally start migrating over to using the Angular CDK Dialog instead of our custom DialogService. Create a new service that wraps around Angular CDK's DialogService. The reason to do this right now is so that there is little confusion over which `DialogService` components are using, though in the future it would probably be best to remove this wrapper service and import the Angular CDK DialogService once we have completely deleted the old one. See #269 for more information. PER-9568: Create new component to select archive type
meisekimiu
added a commit
that referenced
this issue
May 17, 2024
The current DialogService used in the web-app uses deprecated Angular functionality and a few other architectural issues. The new archive type selection component uses a modal to select a type, so this is a good opportunity to finally start migrating over to using the Angular CDK Dialog instead of our custom DialogService. Create a new service that wraps around Angular CDK's DialogService. The reason to do this right now is so that there is little confusion over which `DialogService` components are using, though in the future it would probably be best to remove this wrapper service and import the Angular CDK DialogService once we have completely deleted the old one. See #269 for more information. PER-9568: Create new component to select archive type
meisekimiu
added a commit
that referenced
this issue
May 23, 2024
The current DialogService used in the web-app uses deprecated Angular functionality and a few other architectural issues. The new archive type selection component uses a modal to select a type, so this is a good opportunity to finally start migrating over to using the Angular CDK Dialog instead of our custom DialogService. Create a new service that wraps around Angular CDK's DialogService. The reason to do this right now is so that there is little confusion over which `DialogService` components are using, though in the future it would probably be best to remove this wrapper service and import the Angular CDK DialogService once we have completely deleted the old one. See #269 for more information. PER-9568: Create new component to select archive type
crisnicandrei
pushed a commit
that referenced
this issue
Jun 11, 2024
The current DialogService used in the web-app uses deprecated Angular functionality and a few other architectural issues. The new archive type selection component uses a modal to select a type, so this is a good opportunity to finally start migrating over to using the Angular CDK Dialog instead of our custom DialogService. Create a new service that wraps around Angular CDK's DialogService. The reason to do this right now is so that there is little confusion over which `DialogService` components are using, though in the future it would probably be best to remove this wrapper service and import the Angular CDK DialogService once we have completely deleted the old one. See #269 for more information. PER-9568: Create new component to select archive type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the dialog system used to display modals throughout the app is custom built. This implementation has a few issues. One issue is discussed in #19, but also a few of the dependencies used are currently deprecated and will be removed in future library versions which is something to worry about as we continue to upgrade our version of Angular. The Dialog system also uses various cyclical imports that cause the
import/no-cyclelinting rule to fail when enabled. These cyclical imports cannot be automatically fixed, and are hard to detangle manually without tearing apart the current system.Fortunately, since we have been upgrading Angular regularly now, a new solution has become available to us: The Component Dev Kit Dialog Service
We already import and use
@angular/cdkin our project so this tool is already available to us right now. Because our custom implementation was built to mimic an older Angular dialog library, the CDK Dialog API happens to match the existing API pretty well (with some improvements that would allow us to get rid of things like theDialogComponentTokenandDialogChildComponentDatatypes). Let's use this library instead so we don't have to worry about maintaining the Dialog system ourselves and we can clean up code formatting and linting issues as well.The text was updated successfully, but these errors were encountered: