Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and Contrast Ratio for colors #31

Open
PeterEckIII opened this issue Apr 5, 2023 · 2 comments · Fixed by #40
Open

Accessibility and Contrast Ratio for colors #31

PeterEckIII opened this issue Apr 5, 2023 · 2 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@PeterEckIII
Copy link
Owner

Go through the app and ensure accessibility is taken into account. Also consider looking into contrast ratios to ensure it meets guidlines

@PeterEckIII PeterEckIII added the bug Something isn't working label Apr 5, 2023
@PeterEckIII
Copy link
Owner Author

@PeterEckIII
Copy link
Owner Author

PeterEckIII commented Apr 22, 2023

LikeForm.tsx should have an alreadyLiked property that it inherits from the route. This property will be used to determine which like button is disabled and which is enabled.

The same logic needs to be applied to ReviewHeader.tsx

@PeterEckIII PeterEckIII linked a pull request Apr 22, 2023 that will close this issue
@PeterEckIII PeterEckIII reopened this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant