Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up types #42

Closed
PeterEckIII opened this issue May 6, 2023 · 1 comment · Fixed by #45
Closed

Clean up types #42

PeterEckIII opened this issue May 6, 2023 · 1 comment · Fixed by #45

Comments

@PeterEckIII
Copy link
Owner

PeterEckIII commented May 6, 2023

Types are a mess at the moment and need to be cleaned up. Consider looking into a type system that is easier to extend as well as narrow against (like using discriminated type unions).

Some areas of focus are:

  • Types associated with the Table components. Most of these are defined in routes/services/search/[model]/fetch.tsx. Consider extracting these to the general type system.
  • Types associated with Prisma data fetches. These are defined in models/[model].server.ts
  • Type associated with model creation, editing, and deletion. These are defined in both the [model].server.ts file, as well as used in the routes/[model]/[new|edit|delete]/* directories
@PeterEckIII PeterEckIII linked a pull request May 25, 2023 that will close this issue
Merged
@PeterEckIII
Copy link
Owner Author

#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant