Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about figure 2 #7

Open
gold2718 opened this issue Apr 15, 2018 · 7 comments
Open

Questions about figure 2 #7

gold2718 opened this issue Apr 15, 2018 · 7 comments

Comments

@gold2718
Copy link

Why the different color schemes in figure 2?
I expected the right-hand figure to have four red corner squares, four green edge squares, and one blue center square.
By plotting (I think) nine individual probability distributions on the right, I cannot tell if you have really reduced the bias or just smeared everything out so it is impossible to tell. Why the different approach?

Also, I feel this figure would be hard to understand for a color blind individual. For the left-hand figure, different shapes could be used in addition to different colors. Those shapes could also be used to indicate the different biased probability plots. For the right-hand figure, different stipple patterns could be used. This is in keeping with the 'Accessibility' section of the author guidelines (https://www.ametsoc.org/ams/index.cfm/publications/authors/journal-and-bams-authors/figure-information-for-authors/#Accessibility).

@adamrher
Copy link
Collaborator

hi steve, I agree that for the right figure, creating the three categories you propose would result in a much less noisy figure. But I don't see how doing it the way I did it, would smooth out any signal. What I intended with the figure is for people to notice that the envelope of all 9 curves, clearly spans a smaller range of probabilities, then the envelope of the three curves on the left figure.

Your point is well taken re: difficulty for color blind individuals. For now I'm going to keep the figure as is. I am open to experimenting with the colors when (and if) the reviews come in.

@gold2718
Copy link
Author

But does the figure show that the within-element "bias has been eliminated" as claimed in the caption? Without a similar grouping, I cannot tell. I guess at this point, it is up to a reviewer to be as picky as me.

@adamrher
Copy link
Collaborator

ok, I'm curious enough. the paper is submitted but I will keep this issue open, and get back to you.

@adamrher
Copy link
Collaborator

adamrher commented Jul 6, 2018

Here is a plot where I do as goldy suggests. I think it is an improvement over the previous plot, since it is fair to say that their are 3 types of control volumes that have a different distribution of quadrature nodes within the control volumes (Corners, Edges and the Middle).
temp_pdf.pdf

@adamrher
Copy link
Collaborator

adamrher commented Jul 6, 2018

and I will change the figure caption to say, the bias has been reduced significantly, as opposed to 'eliminated'

@paullric
Copy link
Collaborator

paullric commented Jul 6, 2018 via email

@adamrher
Copy link
Collaborator

adamrher commented Jul 7, 2018

I think the qualitative improvement is the bigger sell. Quantifying the difference between pg2 and pg3, however, might be a worthy exercise ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants