You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Specifically if the match number is a string this is incorrect but doesn't error. This results in much confusion which could be avoided by validation while loading the data.
The text was updated successfully, but these errors were encountered:
Worth noting that this does cause an error when loading the compstate, though the error isn't particularly helpful in identifying the source of the issue:
Traceback (most recent call last):
File "virtualenvs/srcomp/bin/srcomp", line 33, in <module>
sys.exit(load_entry_point('sr.comp.cli', 'console_scripts', 'srcomp')())
File "/home/srobo/srcomp-cli/sr/comp/cli/command_line.py", line 84, in main
settings.func(settings)
File "/home/srobo/srcomp-cli/sr/comp/cli/validate.py", line 10, in command
comp = SRComp(settings.compstate)
File "/home/srobo/srcomp/sr/comp/comp.py", line 68, in __init__
self.scores = scores.Scores.load(
File "/home/srobo/srcomp/sr/comp/scores.py", line 424, in load
return cls(league, knockout, tiebreaker)
File "/home/srobo/srcomp/sr/comp/scores.py", line 449, in __init__
lsm = scores.last_scored_match
File "/home/srobo/srcomp/sr/comp/scores.py", line 267, in last_scored_match
return max(num for arena, num in matches)
TypeError: '>' not supported between instances of 'str' and 'int'
Specifically if the match number is a string this is incorrect but doesn't error. This results in much confusion which could be avoided by validation while loading the data.
The text was updated successfully, but these errors were encountered: