Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it compile with MSVC #4

Open
PeterSommerlad opened this issue Apr 2, 2019 · 1 comment
Open

make it compile with MSVC #4

PeterSommerlad opened this issue Apr 2, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@PeterSommerlad
Copy link
Owner

Describe the bug

Does not yet compile with current MSVC compiler, even though it should be C++17 compatible

To Reproduce

Set up project in MSVC with sources and Tests.

Expected behavior

Compiles and Tests run OK.

@PeterSommerlad PeterSommerlad added the help wanted Extra attention is needed label Apr 2, 2019
@menuet
Copy link
Contributor

menuet commented Sep 3, 2019

Hi Peter
When looking at the readme in the repo, it is not clear whether scope.hpp compiles cleanly with MSVC. However thanks to @JoeyGrajciar's commits, it compiles at least with VS2017 and VS2019.
i think it would be better if the readme states clearly about the tested compilers and would encourage people (like me :-)) to try your library.
I will create a merge request where I add cmake + travis + appveyor stuff at your top-level directory and I replace the warning about MSVC compatibility with CI badges and list of tested compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants