Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Response gets overwritten #124

Open
theluk opened this issue Sep 30, 2016 · 2 comments
Open

GCP Response gets overwritten #124

theluk opened this issue Sep 30, 2016 · 2 comments
Labels
bug enhancement help-wanted

Comments

@theluk
Copy link
Contributor

theluk commented Sep 30, 2016

the batch size is always 100 per push. if i send 200, the sending will be split in two, and when everything is complete, the response will not contain the response of the first delivery.

https://github.com/Ph3nol/NotificationPusher/blob/master/src/Sly/NotificationPusher/Adapter/Gcm.php#L70
@seyfer
Copy link
Collaborator

seyfer commented Nov 1, 2017

@theluk, what do you propose? Merging the result of the every chunk response in one array?

@seyfer
Copy link
Collaborator

seyfer commented Nov 1, 2017

The same issue #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theluk @seyfer