[CombatDamage]-—>SplashList is not correct

[zhnjsacdjkn]

Description

A warhead with Conventional=yes when attack water-face it is always on anim “H2O-EXP1" and is not follow the weapon damage SplashList anim,removing phobos build 43 turn normal.[Original rulesmd.ini with no modify]

Phobos Version

build 43

Conditions to reproduce

Phobos 43 and Ares 3.0p1

INI code

No response

Steps to reproduce

1.Warhead
2.Conventional=yes
3.
...

Expected behaviour

Should follow different weapon damage to show the right SplashList anim.

Actual behaviour

It is always on SplashList anim ”H2O_EXP1"

Additional context

No response

Checklist

• The issue happens on the latest official version of Phobos and wasn't fixed yet.
• I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• I added a very descriptive title to this issue.
• I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[DeathFishAtEase]

In fact, this bug started with #build37,
and Warhead will always use the third one in the SplashList (whether written in [CombatDamage] or [WarheadType]). If there are less than three, the last one will be used.
(Under normal circumstances, it should select the corresponding item in the list based on the value obtained by rounding after Damage/35. Unless it is immediately used as IonCannonWarhead for Type=IonCannon or Trigger Action 94.)
It was introduced in commit: 919a079
BTW
Another bug started with #build35,
where splashes caused by Debris will always use the first one in the [CombatDamage]SplashList=, even if it is IsMeter=true.
(Normally, it should always use the last one unless you have specifically set SplashAnims up)
It was introduced in commit: 97feb46

[zhnjsacdjkn]

In fact, this bug started with #build37, and Warhead will always use the third one in the SplashList (whether written in [CombatDamage] or [WarheadType]). If there are less than three, the last one will be used. (Under normal circumstances, it should select the corresponding item in the list based on the value obtained by rounding after Damage/35. Unless it is immediately used as IonCannonWarhead for Type=IonCannon or Trigger Action 94.) It was introduced in commit: 919a079 BTW Another bug started with #build35, where splashes caused by Debris will always use the first one in the [CombatDamage]SplashList=, even if it is IsMeter=true. (Normally, it should always use the last one unless you have specifically set SplashAnims up) It was introduced in commit: 97feb46

OK thanks,I understand,although it can also controlled by [Warhead]—SplashList I still hope it can be fixed in the later build version.

[Starkku]

Should be fixed in 79a30d3