AircraftTypes don't automatically switch weapons when target goes to air

[mevitar]

Description

Without Phobos (tested with Ares alone for confirmation), AircraftTypes will use one weapon against a unit that is on the ground, and then switch to its anti-air weapon once the target is fully airborne.

With Phobos, AircraftTypes keep firing at units that become airborne with their anti-ground weapon. However, they will switch properly to their anti-air weapon if ordered to attack the same target again.

Phobos Version

eb8150a

Conditions to reproduce

An AircraftType with an anti-ground and anti-air weapon needs to attack a unit (can be AircraftType or jumpjet) that becomes airborne during the attack.

INI code

No response

Steps to reproduce

1. Give an AircraftType two weapons, Primary against ground, Secondary against air, and enough ammo to keep attacking.
2. Attack a flying unit while it is on the ground.
3. Let the AircraftType keep attacking while its target goes airborne.

Expected behaviour

AircraftType should switch to anti-air weapon once its target becomes airborne.

Actual behaviour

AircraftType keeps firing its anti-ground weapon at the airborne target, thus, missing it.

Additional context

This probably isn't a big issue now, but can become a problem if #1366 is implemented.

Checklist

• The issue happens on the latest official version of Phobos and wasn't fixed yet.
• I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• I added a very descriptive title to this issue.
• I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[mevitar]

This is probably caused by 3320a7c

The latest one i have before that build ( 4025827 ) does not have this issue.