-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: include returns undefined for classes #1075
Comments
I'm in favor of the third solution:
because it is the quickest solution, leads to no problems for us as far as I know, and is also the easiest solution to reverse when we found a solution for PhoenicisOrg/phoenicis#2042 |
I would vote for one of the other solutions because
|
What about extending our own include mechanism to provide explicit exports? |
What do we gain with explicit exports? |
Explicit exports make the code easier to understand. In addition we are able to export multiple things in one script. About executing the included scripts in an isolated environment: |
For
it gives "undefined".
For
it gives "class test { myMethod() {}}".
This is caused by a bugfix in graaljs.
Affected:
Possible solutions:
(class C {})
class C {}; C
see PhoenicisOrg/phoenicis#2040
The text was updated successfully, but these errors were encountered: