Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "wizard" from the "preInstall" and "postInstall" Hooks of the Installer Scripts #1125

Open
madoar opened this issue Sep 12, 2019 · 1 comment

Comments

@madoar
Copy link
Collaborator

madoar commented Sep 12, 2019

Currently we pass the two parameters wine (of type Wine) and wizard (of type SetupWizard) to the preInstall and postInstall hooks of the installer scripts. The wizard parameter is redundant because it can also be fetched from wine by calling wine.wizard() therefore we should remove it from both hooks. This will change the syntax of the two hooks to:

Installer.preInstall(wine => {
   ...
});

Installer.postInstall(wine => {
   ...
});

For more details see also #1117 (comment)

@plata
Copy link
Collaborator

plata commented Sep 16, 2019

When fixing this, don't forget documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants