Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity is always zero when simulating #1623

Closed
JochemvdBroek opened this issue Dec 5, 2024 · 1 comment · Fixed by #1653
Closed

Ambiguity is always zero when simulating #1623

JochemvdBroek opened this issue Dec 5, 2024 · 1 comment · Fixed by #1653
Labels
bug Something isn't working

Comments

@JochemvdBroek
Copy link

JochemvdBroek commented Dec 5, 2024

I noticed that the ambiguity of all the poses were zero when running a simulation with the VisionSystemSim, both for single and multi tag results.
I recall that the ambiguity definitely wasn't continuously zero when I ran some simulations in the 2024 version.
That is why I started digging through the code and looking back at old commits and found the following change:

169595e#diff-4a856975e9c0da1c15f66bdc57f7b98300693006a3d290f49c91f9cbed48f7cdL426

Line 426 in PhotonCameraSim.java was changed from OpenCVHelp.solvePNP_SQUARE to solvePNP_SQNP.
This last method defaults the reproduction error to an empty matrix, which I think is the cause of the issue with the ambiguity ratio being zero.

I don't know the exact reason behind this change, but it would be nice if the simulation would once again take into account ambiguity.

@JochemvdBroek JochemvdBroek added the bug Something isn't working label Dec 5, 2024
@amquake
Copy link
Member

amquake commented Dec 9, 2024

@mcm001 SQPNP does not report ambiguity and seemed similar or worse for single-tag estimation ime, was there a reason this was changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants