Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SetupWindow as a Welcome Screen inside the app like other elementary apps #10

Open
Suzie97 opened this issue Jun 19, 2021 · 6 comments

Comments

@Suzie97
Copy link
Member

Suzie97 commented Jun 19, 2021

At the moment, we show the setup window before loading the main window like pixelmator pro. And then ask the user to either open a new project, or import existing photos etc.

Screenshot from 2021-06-19 14-44-44

I've been reading the docs lately and thinking about this, the reason we decided to implement an extra window at the first place was purely for UI purposes. I've never felt very happy with the impact of this decision on the UX of the app.

If we incorporate the welcome view provided by elementary inside the app window, it will feel like the app is fast, the initial barrier to get to work will be decreased as less setup will be required.

This will also be more consistent with other elementary apps. Also, theoretically, it should give us some performance boost as less resources will be loaded. Users who'll be regularly using the app would also find this extra window annoying because they know the layout of the app and how it works.

And in the future, if the elementary team decides to change the welcome view, we get it for free without tweaking our existing code.

@syfds, @abdallah-moh please share your thoughts on this.

@ghost
Copy link

ghost commented Jun 19, 2021

I think that the window is much user friendly stacking every thing in one window will be a mess

@ghost ghost added the Needs discussion label Jun 19, 2021
@Suzie97
Copy link
Member Author

Suzie97 commented Jun 19, 2021

I think that the window is much user friendly stacking every thing in one window will be a mess

I don't think so, because the welcome screen will only be displayed when a current project is not open. So when nothing is open, there will be no layers, no properties nothing, just the tools sidebar and the headerbar.

@colinkiama
Copy link
Member

I think that the window is much user friendly stacking every thing in one window will be a mess

If this is ever becomes a problem then we coded it wrong in my opinion.

Single window makes more sense to me. We could copy how the elementary devs have implemented their welcome screens.

@Suzie97
Copy link
Member Author

Suzie97 commented Jul 10, 2021

@colinkiama , @abdallah-moh As we decided to implement a single window approach, now we need to decide if we should expose the ToolsSidebar, Layers Panel and Properties Panel along with the welcome screen in the middle or if we should use display the welcome widget in the middle grid along with the panels and tools?

As far as prior art goes, elementary apps do expose other elements of the MainWindow UI along with the welcome screen.

Screenshot from 2021-07-10 07-15-44
Screenshot from 2021-07-10 07-14-46

@ghost
Copy link

ghost commented Jul 10, 2021

@Suzie97 We should not

@colinkiama
Copy link
Member

Yeah there's no point 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants