From 3d27c49ee6d3b1f7d9144a8b2d8866644da5fe78 Mon Sep 17 00:00:00 2001 From: David Yackzan Date: Thu, 2 Jan 2025 17:31:59 -0700 Subject: [PATCH] Use new Pro RRT SetupMTCPlanTo_ behaviors Replace: * `SetupMTCMoveToPose` -> `SetupMTCPlanToPose` * `SetupMTCMoveToJointState` -> `SetupMTCPlanToJointState` Remove deprecated `planner_interface` port. The new behaviors expose more planning parameters for the Pro RRT Connect planner. --- src/fanuc_sim/objectives/move_to_pose.xml | 3 +-- src/lab_sim/objectives/add_waypoints_to_mtc_task.xml | 12 ++++-------- src/lab_sim/objectives/joint_diagnostic.xml | 3 --- .../objectives/load_and_execute_joint_trajectory.xml | 1 - src/lab_sim/objectives/plan_and_save_trajectory.xml | 2 -- src/lab_sim/objectives/plan_move_to_pose.xml | 3 +-- src/lab_sim/objectives/plan_to_pose.xml | 3 +-- .../description/robotiq_2f_85_macro.xacro | 2 -- .../objectives/move_to_pose.xml | 2 +- .../objectives/compliant_grasp_rafti.xml | 2 +- .../objectives/compliant_grasp_rafti_vfc.xml | 2 +- .../objectives/constrained_pick_place.xml | 1 - .../objectives/move_to_pose.xml | 2 +- .../00_solution_-_move_to_initial_pose.xml | 1 - .../objectives/20_solution_-_look_at_the_airfoil.xml | 1 - .../objectives/21_solution_-_find_the_airfoil.xml | 1 - .../22_solution_-_visualize_airfoil_frame.xml | 1 - .../23_solution_-_airfoil_coverage_origin.xml | 1 - .../24_solution_-_airfoil_coverage_path.xml | 1 - .../25_solution_-_execute_airfoil_coverage.xml | 1 - .../objectives/26_solution_-_better_coverage.xml | 1 - .../objectives/move_to_a_stampedpose.xml | 3 +-- .../objectives/3_waypoint_pick_and_place.xml | 9 --------- .../objectives/constrained_pick_place.xml | 11 ----------- .../objectives/cycle_between_waypoints.xml | 2 -- .../arm_on_rail_sim/objectives/joint_diagnostic.xml | 3 --- .../objectives/move_with_velocity_and_force.xml | 1 - .../objectives/move_to_pose.xml | 3 +-- .../objectives/3_waypoint_pick_and_place.xml | 9 --------- .../objectives/constrained_pick_place.xml | 2 -- .../objectives/cycle_between_waypoints.xml | 2 -- .../objectives/joint_diagnostic.xml | 3 --- .../objectives/move_along_path.xml | 1 - .../objectives/move_to_pose.xml | 3 +-- .../objectives/close_cabinet_door.xml | 2 +- .../objectives/inspect_surface.xml | 3 +-- .../objectives/looping_pick_and_place_object.xml | 4 ---- .../objectives/open_door_fixed_handle_ml.xml | 4 ---- .../objectives/open_door_lever_handle_ml.xml | 1 - .../objectives/pick_apriltag_labeled_object.xml | 1 - .../objectives/pick_place_object.xml | 3 --- .../objectives/push_button.xml | 3 +-- .../objectives/push_button_ml.xml | 4 +--- .../objectives/retreat_to_initial_pose.xml | 2 +- 44 files changed, 19 insertions(+), 106 deletions(-) diff --git a/src/fanuc_sim/objectives/move_to_pose.xml b/src/fanuc_sim/objectives/move_to_pose.xml index 4009dca1..4125bf45 100644 --- a/src/fanuc_sim/objectives/move_to_pose.xml +++ b/src/fanuc_sim/objectives/move_to_pose.xml @@ -14,12 +14,11 @@ /> @@ -17,11 +16,10 @@ joint_group_name="{joint_group_name}" /> @@ -43,7 +40,6 @@ - diff --git a/src/lab_sim/objectives/joint_diagnostic.xml b/src/lab_sim/objectives/joint_diagnostic.xml index aebb7879..a9753934 100644 --- a/src/lab_sim/objectives/joint_diagnostic.xml +++ b/src/lab_sim/objectives/joint_diagnostic.xml @@ -12,7 +12,6 @@ waypoint_name="Look at Table" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -22,14 +21,12 @@ waypoint_name="Wrist 2 Max" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/lab_sim/objectives/load_and_execute_joint_trajectory.xml b/src/lab_sim/objectives/load_and_execute_joint_trajectory.xml index c7c05f3e..c148ed65 100644 --- a/src/lab_sim/objectives/load_and_execute_joint_trajectory.xml +++ b/src/lab_sim/objectives/load_and_execute_joint_trajectory.xml @@ -13,7 +13,6 @@ _collapsed="true" waypoint_name="Workspace Right" joint_group_name="manipulator" - planner_interface="moveit_default" controller_names="/joint_trajectory_controller" /> diff --git a/src/lab_sim/objectives/plan_move_to_pose.xml b/src/lab_sim/objectives/plan_move_to_pose.xml index 0d3be8df..1ecd691b 100644 --- a/src/lab_sim/objectives/plan_move_to_pose.xml +++ b/src/lab_sim/objectives/plan_move_to_pose.xml @@ -15,12 +15,11 @@ /> diff --git a/src/moveit_pro_kinova_configs/kinova_gen3_base_config/description/robotiq_2f_85_macro.xacro b/src/moveit_pro_kinova_configs/kinova_gen3_base_config/description/robotiq_2f_85_macro.xacro index 3f7e6316..632eab91 100644 --- a/src/moveit_pro_kinova_configs/kinova_gen3_base_config/description/robotiq_2f_85_macro.xacro +++ b/src/moveit_pro_kinova_configs/kinova_gen3_base_config/description/robotiq_2f_85_macro.xacro @@ -7,8 +7,6 @@ fake_sensor_commands:=false sim_ignition:=false sim_isaac:=false - isaac_joint_commands:=/isaac_joint_commands - isaac_joint_states:=/isaac_joint_states use_internal_bus_gripper_comm:=false com_port:=/dev/ttyUSB0 moveit_active:=false"> diff --git a/src/moveit_pro_kinova_configs/kinova_gen3_base_config/objectives/move_to_pose.xml b/src/moveit_pro_kinova_configs/kinova_gen3_base_config/objectives/move_to_pose.xml index 24d83b61..f8aa6f89 100644 --- a/src/moveit_pro_kinova_configs/kinova_gen3_base_config/objectives/move_to_pose.xml +++ b/src/moveit_pro_kinova_configs/kinova_gen3_base_config/objectives/move_to_pose.xml @@ -19,7 +19,7 @@ /> - + - + diff --git a/src/moveit_pro_kinova_configs/kinova_gen3_mujoco_config/objectives/move_to_pose.xml b/src/moveit_pro_kinova_configs/kinova_gen3_mujoco_config/objectives/move_to_pose.xml index fca077c6..8884959d 100644 --- a/src/moveit_pro_kinova_configs/kinova_gen3_mujoco_config/objectives/move_to_pose.xml +++ b/src/moveit_pro_kinova_configs/kinova_gen3_mujoco_config/objectives/move_to_pose.xml @@ -19,7 +19,7 @@ /> diff --git a/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/20_solution_-_look_at_the_airfoil.xml b/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/20_solution_-_look_at_the_airfoil.xml index 0eb08894..9e27b13f 100644 --- a/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/20_solution_-_look_at_the_airfoil.xml +++ b/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/20_solution_-_look_at_the_airfoil.xml @@ -12,7 +12,6 @@ waypoint_name="Look at Airfoil" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/21_solution_-_find_the_airfoil.xml b/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/21_solution_-_find_the_airfoil.xml index dcd90294..a58852a6 100644 --- a/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/21_solution_-_find_the_airfoil.xml +++ b/src/moveit_pro_mobile_manipulation/mobile_manipulation_config/objectives/21_solution_-_find_the_airfoil.xml @@ -13,7 +13,6 @@ waypoint_name="Look at Airfoil" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -67,7 +63,6 @@ waypoint_name="Look at Table" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" constraints="{constraints}" /> @@ -78,7 +73,6 @@ waypoint_name="Place Cube" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" constraints="{constraints}" /> diff --git a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/constrained_pick_place.xml b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/constrained_pick_place.xml index 27768be0..21d4423a 100644 --- a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/constrained_pick_place.xml +++ b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/constrained_pick_place.xml @@ -12,7 +12,6 @@ constraints="{constraints}" waypoint_name="Look at Table" joint_group_name="manipulator" - planner_interface="moveit_default" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" /> @@ -37,7 +36,6 @@ waypoint_name="Above Pick Cube" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" constraints="{constraints}" /> @@ -47,7 +45,6 @@ waypoint_name="Pick Cube" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" constraints="{constraints}" /> @@ -59,7 +56,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Above Pick Cube" @@ -70,7 +66,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Above Place Cube" @@ -81,7 +76,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Place Cube" @@ -93,7 +87,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Above Place Cube" @@ -104,7 +97,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Place Cube" @@ -116,7 +108,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Above Place Cube" @@ -127,7 +118,6 @@ ID="Move to Waypoint" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" - planner_interface="moveit_default" constraints="{constraints}" _collapsed="true" waypoint_name="Above Pick Cube" @@ -139,7 +129,6 @@ waypoint_name="Pick Cube" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" constraints="{constraints}" /> diff --git a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/cycle_between_waypoints.xml b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/cycle_between_waypoints.xml index 054c2195..7b6642c4 100644 --- a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/cycle_between_waypoints.xml +++ b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/cycle_between_waypoints.xml @@ -11,7 +11,6 @@ waypoint_name="Above Pick Cube" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="pro_rrt" constraints="{constraints}" /> diff --git a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/joint_diagnostic.xml b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/joint_diagnostic.xml index d85ebde7..25c54af2 100644 --- a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/joint_diagnostic.xml +++ b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/joint_diagnostic.xml @@ -12,7 +12,6 @@ waypoint_name="Look at Table" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -22,14 +21,12 @@ waypoint_name="Wrist 2 Max" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/move_with_velocity_and_force.xml b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/move_with_velocity_and_force.xml index 1b5085d4..68acc707 100644 --- a/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/move_with_velocity_and_force.xml +++ b/src/moveit_pro_ur_configs/arm_on_rail_sim/objectives/move_with_velocity_and_force.xml @@ -12,7 +12,6 @@ _collapsed="true" waypoint_name="VFC Start" joint_group_name="manipulator" - planner_interface="pro_rrt" controller_names="/joint_trajectory_controller" /> @@ -73,7 +68,6 @@ waypoint_name="Grasp Machine" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/constrained_pick_place.xml b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/constrained_pick_place.xml index 1fdc14b1..94c578f6 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/constrained_pick_place.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/constrained_pick_place.xml @@ -28,7 +28,6 @@ waypoint_name="Grasp Right" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -40,7 +39,6 @@ controller_names="/joint_trajectory_controller /robotiq_gripper_controller" joint_group_name="manipulator" waypoint_name="Grasp Left" - planner_interface="moveit_default" constraints="{constraints}" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/cycle_between_waypoints.xml b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/cycle_between_waypoints.xml index b5bbf2b2..6473c274 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/cycle_between_waypoints.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/cycle_between_waypoints.xml @@ -12,14 +12,12 @@ waypoint_name="Grasp Left" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="pro_rrt" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/joint_diagnostic.xml b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/joint_diagnostic.xml index c785d370..abb19b70 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/joint_diagnostic.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/joint_diagnostic.xml @@ -13,7 +13,6 @@ waypoint_name="Home" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -23,14 +22,12 @@ waypoint_name="Wrist 2 Max" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/move_along_path.xml b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/move_along_path.xml index 2f6b3592..07927e37 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/move_along_path.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_mock_hw_config/objectives/move_along_path.xml @@ -79,7 +79,6 @@ waypoint_name="Look at Right Table" joint_group_name="manipulator" controller_names="/joint_trajectory_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/looping_pick_and_place_object.xml b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/looping_pick_and_place_object.xml index 34f8145c..d06e1542 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/looping_pick_and_place_object.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/looping_pick_and_place_object.xml @@ -34,7 +34,6 @@ waypoint_name="Look at Pick and Place Zone" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -156,7 +155,6 @@ waypoint_name="Look at Pick and Place Zone" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -165,7 +163,6 @@ waypoint_name="{place_waypoint}" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/open_door_fixed_handle_ml.xml b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/open_door_fixed_handle_ml.xml index c06ba096..f7f32c20 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/open_door_fixed_handle_ml.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/open_door_fixed_handle_ml.xml @@ -23,7 +23,6 @@ waypoint_name="Extended Right" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -47,7 +46,6 @@ waypoint_name="Extended Right 2" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/pick_apriltag_labeled_object.xml b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/pick_apriltag_labeled_object.xml index 5b3f8ef6..df75ca36 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/pick_apriltag_labeled_object.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/pick_apriltag_labeled_object.xml @@ -14,7 +14,6 @@ waypoint_name="Look at April Tag" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -284,7 +282,6 @@ waypoint_name="Look at Pick and Place Zone" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button.xml b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button.xml index 5332fb9f..a21b3a9d 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button.xml @@ -46,12 +46,11 @@ input_pose="{pose}" /> diff --git a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button_ml.xml b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button_ml.xml index c9a0e65f..0490707d 100644 --- a/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button_ml.xml +++ b/src/moveit_pro_ur_configs/picknik_ur_site_config/objectives/push_button_ml.xml @@ -12,7 +12,6 @@ waypoint_name="Hinge View" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" - planner_interface="moveit_default" /> @@ -101,12 +100,11 @@ />