From 5f0c39ace3b3b17d1eaff45ca9fc2a285a000725 Mon Sep 17 00:00:00 2001 From: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Date: Thu, 18 Jul 2024 02:50:14 -0400 Subject: [PATCH] Remove mimic tags and rename `sim_ignition` to `sim_gazebo` (#54) --- .github/workflows/ci-coverage-build.yml | 6 +- .../workflows/humble-binary-build-main.yml | 26 ------- .../workflows/humble-binary-build-testing.yml | 26 ------- .../humble-semi-binary-build-main.yml | 25 ------ .../humble-semi-binary-build-testing.yml | 25 ------ .github/workflows/humble-source-build.yml | 19 ----- .github/workflows/iron-binary-build-main.yml | 26 ------- .../workflows/iron-binary-build-testing.yml | 26 ------- .../workflows/iron-semi-binary-build-main.yml | 25 ------ .../iron-semi-binary-build-testing.yml | 25 ------ .github/workflows/iron-source-build.yml | 19 ----- .../reusable-ros-tooling-source-build.yml | 2 +- .../urdf/2f_140.ros2_control.xacro | 37 +++------ .../urdf/2f_85.ros2_control.xacro | 37 +++------ .../urdf/robotiq_2f_140_macro.urdf.xacro | 4 +- .../urdf/robotiq_2f_85_macro.urdf.xacro | 4 +- robotiq_driver/package.xml | 1 - robotiq_driver/tests/CMakeLists.txt | 5 +- robotiq_driver/tests/test_data_utils.cpp | 2 + ...est_robotiq_gripper_hardware_interface.cpp | 76 ++++++++++--------- ..._robotiq_gripper-not-released.humble.repos | 5 -- ros2_robotiq_gripper-not-released.iron.repos | 5 -- ros2_robotiq_gripper.humble.repos | 5 -- ros2_robotiq_gripper.iron.repos | 5 -- 24 files changed, 75 insertions(+), 361 deletions(-) delete mode 100644 .github/workflows/humble-binary-build-main.yml delete mode 100644 .github/workflows/humble-binary-build-testing.yml delete mode 100644 .github/workflows/humble-semi-binary-build-main.yml delete mode 100644 .github/workflows/humble-semi-binary-build-testing.yml delete mode 100644 .github/workflows/humble-source-build.yml delete mode 100644 .github/workflows/iron-binary-build-main.yml delete mode 100644 .github/workflows/iron-binary-build-testing.yml delete mode 100644 .github/workflows/iron-semi-binary-build-main.yml delete mode 100644 .github/workflows/iron-semi-binary-build-testing.yml delete mode 100644 .github/workflows/iron-source-build.yml delete mode 100644 ros2_robotiq_gripper-not-released.humble.repos delete mode 100644 ros2_robotiq_gripper-not-released.iron.repos delete mode 100644 ros2_robotiq_gripper.humble.repos delete mode 100644 ros2_robotiq_gripper.iron.repos diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index 32d176c..3abc846 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -10,7 +10,7 @@ on: jobs: coverage: name: coverage build - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: fail-fast: false env: @@ -39,12 +39,12 @@ jobs: } } colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/master/index.yaml - - uses: codecov/codecov-action@v3.1.0 + - uses: codecov/codecov-action@v4 with: file: ros_ws/lcov/total_coverage.info flags: unittests name: codecov-umbrella - - uses: actions/upload-artifact@v3.1.0 + - uses: actions/upload-artifact@v4 with: name: colcon-logs-coverage-rolling path: ros_ws/log diff --git a/.github/workflows/humble-binary-build-main.yml b/.github/workflows/humble-binary-build-main.yml deleted file mode 100644 index fd97c85..0000000 --- a/.github/workflows/humble-binary-build-main.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: Humble Binary Build - main -# author: Denis Štogl -# description: 'Build & test all dependencies from released (binary) packages.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' - -jobs: - binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: humble - ros_repo: main - upstream_workspace: ros2_robotiq_gripper-not-released.humble.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/humble-binary-build-testing.yml b/.github/workflows/humble-binary-build-testing.yml deleted file mode 100644 index 36076de..0000000 --- a/.github/workflows/humble-binary-build-testing.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: Humble Binary Build - testing -# author: Denis Štogl -# description: 'Build & test all dependencies from released (binary) packages.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' - -jobs: - binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: humble - ros_repo: testing - upstream_workspace: ros2_robotiq_gripper-not-released.humble.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/humble-semi-binary-build-main.yml b/.github/workflows/humble-semi-binary-build-main.yml deleted file mode 100644 index 17ababa..0000000 --- a/.github/workflows/humble-semi-binary-build-main.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Humble Semi-Binary Build - main -# description: 'Build & test that compiles the main dependencies from source.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '33 1 * * *' - -jobs: - semi_binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: humble - ros_repo: main - upstream_workspace: ros2_robotiq_gripper.humble.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/humble-semi-binary-build-testing.yml b/.github/workflows/humble-semi-binary-build-testing.yml deleted file mode 100644 index 0292176..0000000 --- a/.github/workflows/humble-semi-binary-build-testing.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Humble Semi-Binary Build - testing -# description: 'Build & test that compiles the main dependencies from source.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '33 1 * * *' - -jobs: - semi_binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: humble - ros_repo: testing - upstream_workspace: ros2_robotiq_gripper.humble.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/humble-source-build.yml b/.github/workflows/humble-source-build.yml deleted file mode 100644 index 9869d1f..0000000 --- a/.github/workflows/humble-source-build.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Humble Source Build -on: - workflow_dispatch: - branches: - - main - push: - branches: - - main - schedule: - # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' - -jobs: - source: - uses: ./.github/workflows/reusable-ros-tooling-source-build.yml - with: - ros_distro: humble - ref: main - ros2_repo_branch: humble diff --git a/.github/workflows/iron-binary-build-main.yml b/.github/workflows/iron-binary-build-main.yml deleted file mode 100644 index cea9495..0000000 --- a/.github/workflows/iron-binary-build-main.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: Iron Binary Build - main -# author: Denis Štogl -# description: 'Build & test all dependencies from released (binary) packages.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' - -jobs: - binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: iron - ros_repo: main - upstream_workspace: ros2_robotiq_gripper-not-released.iron.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/iron-binary-build-testing.yml b/.github/workflows/iron-binary-build-testing.yml deleted file mode 100644 index 9470611..0000000 --- a/.github/workflows/iron-binary-build-testing.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: Iron Binary Build - testing -# author: Denis Štogl -# description: 'Build & test all dependencies from released (binary) packages.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' - -jobs: - binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: iron - ros_repo: testing - upstream_workspace: ros2_robotiq_gripper-not-released.iron.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/iron-semi-binary-build-main.yml b/.github/workflows/iron-semi-binary-build-main.yml deleted file mode 100644 index ac9efb5..0000000 --- a/.github/workflows/iron-semi-binary-build-main.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Iron Semi-Binary Build - main -# description: 'Build & test that compiles the main dependencies from source.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '33 1 * * *' - -jobs: - semi_binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: iron - ros_repo: main - upstream_workspace: ros2_robotiq_gripper.iron.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/iron-semi-binary-build-testing.yml b/.github/workflows/iron-semi-binary-build-testing.yml deleted file mode 100644 index ec93f8f..0000000 --- a/.github/workflows/iron-semi-binary-build-testing.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Iron Semi-Binary Build - testing -# description: 'Build & test that compiles the main dependencies from source.' - -on: - workflow_dispatch: - branches: - - main - pull_request: - branches: - - main - push: - branches: - - main - schedule: - # Run every morning to detect flakiness and broken dependencies - - cron: '33 1 * * *' - -jobs: - semi_binary: - uses: ./.github/workflows/reusable-industrial-ci-with-cache.yml - with: - ros_distro: iron - ros_repo: testing - upstream_workspace: ros2_robotiq_gripper.iron.repos - ref_for_scheduled_build: main diff --git a/.github/workflows/iron-source-build.yml b/.github/workflows/iron-source-build.yml deleted file mode 100644 index 350896d..0000000 --- a/.github/workflows/iron-source-build.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Iron Source Build -on: - workflow_dispatch: - branches: - - main - push: - branches: - - main - schedule: - # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' - -jobs: - source: - uses: ./.github/workflows/reusable-ros-tooling-source-build.yml - with: - ros_distro: iron - ref: main - ros2_repo_branch: iron diff --git a/.github/workflows/reusable-ros-tooling-source-build.yml b/.github/workflows/reusable-ros-tooling-source-build.yml index 86c1f72..e2a6bcd 100644 --- a/.github/workflows/reusable-ros-tooling-source-build.yml +++ b/.github/workflows/reusable-ros-tooling-source-build.yml @@ -45,7 +45,7 @@ jobs: https://raw.githubusercontent.com/ros2/ros2/${{ inputs.ros2_repo_branch }}/ros2.repos https://raw.githubusercontent.com/${{ github.repository }}/${{ github.sha }}/ros2_robotiq_gripper.${{ inputs.ros_distro }}.repos?token=${{ secrets.GITHUB_TOKEN }} colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/master/index.yaml - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 with: name: colcon-logs-ubuntu-22.04 path: ros_ws/log diff --git a/robotiq_description/urdf/2f_140.ros2_control.xacro b/robotiq_description/urdf/2f_140.ros2_control.xacro index 80c4294..d4b1b8f 100644 --- a/robotiq_description/urdf/2f_140.ros2_control.xacro +++ b/robotiq_description/urdf/2f_140.ros2_control.xacro @@ -4,7 +4,7 @@ ${isaac_joint_commands} ${isaac_joint_states} - + ign_ros2_control/IgnitionSystem @@ -28,7 +28,7 @@ ${fake_sensor_commands} 0.0 - + robotiq_driver/RobotiqGripperHardwareInterface 0.695 ${com_port} @@ -38,7 +38,7 @@ - + @@ -47,48 +47,33 @@ - + - ${prefix}finger_joint - -1 - - + - ${prefix}finger_joint - 1 - - + - ${prefix}finger_joint - -1 - - + - ${prefix}finger_joint - -1 - - + - ${prefix}finger_joint - 1 - - + @@ -96,7 +81,7 @@ - + diff --git a/robotiq_description/urdf/2f_85.ros2_control.xacro b/robotiq_description/urdf/2f_85.ros2_control.xacro index 96d3969..b488e97 100644 --- a/robotiq_description/urdf/2f_85.ros2_control.xacro +++ b/robotiq_description/urdf/2f_85.ros2_control.xacro @@ -4,7 +4,7 @@ ${isaac_joint_states} 0.02 - + ign_ros2_control/IgnitionSystem @@ -33,7 +33,7 @@ ${fake_sensor_commands} 0.0 - + robotiq_driver/RobotiqGripperHardwareInterface 0.7929 ${com_port} @@ -43,7 +43,7 @@ - + @@ -52,48 +52,33 @@ - + - ${prefix}robotiq_85_left_knuckle_joint - -1 - - + - ${prefix}robotiq_85_left_knuckle_joint - 1 - - + - ${prefix}robotiq_85_left_knuckle_joint - -1 - - + - ${prefix}robotiq_85_left_knuckle_joint - -1 - - + - ${prefix}robotiq_85_left_knuckle_joint - 1 - - + @@ -101,7 +86,7 @@ - + diff --git a/robotiq_description/urdf/robotiq_2f_140_macro.urdf.xacro b/robotiq_description/urdf/robotiq_2f_140_macro.urdf.xacro index 9a2cc7d..9423d8c 100644 --- a/robotiq_description/urdf/robotiq_2f_140_macro.urdf.xacro +++ b/robotiq_description/urdf/robotiq_2f_140_macro.urdf.xacro @@ -5,7 +5,7 @@ prefix parent *origin - sim_ignition:=false + sim_gazebo:=false sim_isaac:=false isaac_joint_commands:=/isaac_joint_commands isaac_joint_states:=/isaac_joint_states @@ -20,7 +20,7 @@ ament_cmake_gmock - ros2_control_test_assets ament_cmake diff --git a/robotiq_driver/tests/CMakeLists.txt b/robotiq_driver/tests/CMakeLists.txt index 357e1d8..5db0b3c 100644 --- a/robotiq_driver/tests/CMakeLists.txt +++ b/robotiq_driver/tests/CMakeLists.txt @@ -2,7 +2,6 @@ find_package(ament_cmake_gtest REQUIRED) find_package(ament_cmake_gmock REQUIRED) find_package(ament_lint_auto REQUIRED) -find_package(ros2_control_test_assets REQUIRED) ament_lint_auto_find_test_dependencies() @@ -21,9 +20,7 @@ target_include_directories(test_robotiq_gripper_hardware_interface PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ) target_link_libraries(test_robotiq_gripper_hardware_interface robotiq_driver) -ament_target_dependencies(test_robotiq_gripper_hardware_interface - ros2_control_test_assets -) +ament_target_dependencies(test_robotiq_gripper_hardware_interface) ############################################################################### # test_default_serial_factory diff --git a/robotiq_driver/tests/test_data_utils.cpp b/robotiq_driver/tests/test_data_utils.cpp index 61312c4..c5f74c1 100644 --- a/robotiq_driver/tests/test_data_utils.cpp +++ b/robotiq_driver/tests/test_data_utils.cpp @@ -25,7 +25,9 @@ // CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE // POSSIBILITY OF SUCH DAMAGE. + #include + #include namespace robotiq_driver::test diff --git a/robotiq_driver/tests/test_robotiq_gripper_hardware_interface.cpp b/robotiq_driver/tests/test_robotiq_gripper_hardware_interface.cpp index 7b058fd..b187a80 100644 --- a/robotiq_driver/tests/test_robotiq_gripper_hardware_interface.cpp +++ b/robotiq_driver/tests/test_robotiq_gripper_hardware_interface.cpp @@ -26,24 +26,11 @@ // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE // POSSIBILITY OF SUCH DAMAGE. -#include #include -#include - -#include -#include - -#include -#include #include -#include -#include -#include - -#include -#include +#include namespace robotiq_driver::test { @@ -54,31 +41,52 @@ namespace robotiq_driver::test */ TEST(TestRobotiqGripperHardwareInterface, load_urdf) { - std::string urdf_control_ = + std::string urdf = R"( - - - robotiq_driver/RobotiqGripperHardwareInterface - 1.0 - 0.5 - /dev/ttyUSB0 - 0.7929 - - - - - 0.7929 - - - - - )"; + + + + + + + + + + + + + + robotiq_driver/RobotiqGripperHardwareInterface + 1.0 + 0.5 + /dev/ttyUSB0 + 0.7929 + + + + + 0.7929 + + + + + + )"; + + rclcpp::Node node{ "test_robotiq_gripper_hardware_interface" }; - auto urdf = ros2_control_test_assets::urdf_head + urdf_control_ + ros2_control_test_assets::urdf_tail; - hardware_interface::ResourceManager rm(urdf); + // Initialize the resource manager + hardware_interface::ResourceManager rm(urdf, node.get_node_clock_interface(), node.get_node_logging_interface()); // Check interfaces EXPECT_EQ(1u, rm.system_components_size()); } } // namespace robotiq_driver::test + +int main(int argc, char** argv) +{ + rclcpp::init(argc, argv); + testing::InitGoogleTest(&argc, argv); + return RUN_ALL_TESTS(); +} diff --git a/ros2_robotiq_gripper-not-released.humble.repos b/ros2_robotiq_gripper-not-released.humble.repos deleted file mode 100644 index 510d9bc..0000000 --- a/ros2_robotiq_gripper-not-released.humble.repos +++ /dev/null @@ -1,5 +0,0 @@ -repositories: - serial: - type: git - url: https://github.com/tylerjw/serial.git - version: ros2 diff --git a/ros2_robotiq_gripper-not-released.iron.repos b/ros2_robotiq_gripper-not-released.iron.repos deleted file mode 100644 index 510d9bc..0000000 --- a/ros2_robotiq_gripper-not-released.iron.repos +++ /dev/null @@ -1,5 +0,0 @@ -repositories: - serial: - type: git - url: https://github.com/tylerjw/serial.git - version: ros2 diff --git a/ros2_robotiq_gripper.humble.repos b/ros2_robotiq_gripper.humble.repos deleted file mode 100644 index 510d9bc..0000000 --- a/ros2_robotiq_gripper.humble.repos +++ /dev/null @@ -1,5 +0,0 @@ -repositories: - serial: - type: git - url: https://github.com/tylerjw/serial.git - version: ros2 diff --git a/ros2_robotiq_gripper.iron.repos b/ros2_robotiq_gripper.iron.repos deleted file mode 100644 index 510d9bc..0000000 --- a/ros2_robotiq_gripper.iron.repos +++ /dev/null @@ -1,5 +0,0 @@ -repositories: - serial: - type: git - url: https://github.com/tylerjw/serial.git - version: ros2