Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing a graphics pack, confirm before installing DFHack init files #154

Open
Pidgeot opened this issue Apr 4, 2020 · 1 comment

Comments

@Pidgeot
Copy link
Owner

Pidgeot commented Apr 4, 2020

I've recently received reports that some graphics packs include DFHack onLoad.init scripts which have been causing various problems by adjusting TwbT settings.

We should probably have users confirm before installing new DFHack init files in graphics packs, and possibly also for mods (though it's more normal there).

[Issue created by PeridexisErrant: 2017-06-18]

@jecowa
Copy link
Contributor

jecowa commented Apr 4, 2020

The setting that's the biggest problem is twbt redraw_all 1. It forces everything to be redrawn every frame, which fixes issues with tiles shifting around, but it also makes the game unstable. Maybe give a special warning if this is present, and maybe the option to disable just this one line and allow the rest.

Settings like these are completely harmless (just changes the color and opacity of multi-level rendering overlays for when it's enabled):

multilevel shadowcolor 0 0 0 0.6
multilevel fogcolor 0.1 0.1 0.17
multilevel fogdensity 0.30 0.25 0.75

This is the most common use of the onLoad*.init file: twbt unit_transparency 1. I think this is safe and allows creature graphics to have transparent backgrounds. And the twbt workshop_transparency 1 is probably safe too– it makes the floors of workshops invisible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants