You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CamDavidsonPilon
changed the title
Removing/unassigning leader from experiment with a running profile will end the profile
Removing/unassigning/inactivating a leader from experiment with a running profile will end the profile
Apr 2, 2024
When a leader runs a profile, the job is saved to it's local job DB with the metadata name="experiment_profile", job_source="user", experiment="<experiment>", unit="<leader>", pid=<number>.
When a unit:
goes inactive, the following runs: pio kill --all-jobs. This kills all jobs, expect those we deem "long-running"
gets unassigned, the following runs: pio kill --experiment <exp>, this kills all jobs tagged with experiment="<exp>".
gets removed: this can't happen to leader, so moot.
What if we make experiment profile as "long running?" Inactive would not kill it, but unassigned would.
What if we make experiment profile not associated to an experiment? This would create conflicts if multiple profiles want to run for different experiments. It's also not clear how to kill it (and only it) from the command line: pio kill --name experiment_profile would kill all profiles, and pio kill --name experiment_profile --experiment <exp> would kill nothing.
Probably something along the lines of 1. makes more sense. However, what does kill this profile? pio kill --name experiment_profile --experiment <exp>, or over MQTT (UI). How do we handle unassignment killing it?
This is solved with the introduction of more logic in the JobManager. We went with a "make exp profiles long-running". A user must explicitly end a profile.
No description provided.
The text was updated successfully, but these errors were encountered: