Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Prettier from CI #27

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Remove Prettier from CI #27

merged 1 commit into from
Mar 3, 2023

Conversation

PistolRcks
Copy link
Owner

@PistolRcks PistolRcks commented Mar 2, 2023 •
edited by lmschaff
Loading

For Pull Requesters/Reviewers:

All of the following should be true before making a pull request and should be inspected by reviewers:

User Story

Not applicable: does not pertain to a User Story.

Unit Testing

Not applicable: does not contain any unit testable code.

Documentation/Style

  • JSDocs are written for methods and components (N/A: Does not contain any Javascript code)
  • Unclear code has been documented (N/A: Code was removed)
  • Style standards are adhered to (N/A: Code was removed)

For Reviewers:

The following should be additionally checked by reviewers:

  • Code runs locally
  • Visually inspect tests; they should not simply pass, but rather they should be doing something and testing acceptance criteria
  • See if "jank" code could be rewritten

Description

This PR removes the Prettier Github Action. This has been erroneously stating that PRs fail due to the action being flaky. This is probably due to creyD/prettier_action#61.

Therefore, we will discontinue use of the Prettier Action for now, but Prettier (as a VSCode extension) should still be used for prettifying code.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Ready for review by @connormckellips @lmschaff

@lmschaff lmschaff merged commit cfd5ce6 into master Mar 3, 2023
@lmschaff lmschaff deleted the remove-prettier-ci branch March 3, 2023 18:20
lmschaff added a commit that referenced this pull request Mar 3, 2023
@lmschaff
Squashed commit of the following:
6b6af83 
commit cfd5ce6
Merge: 05c5b84 d4b230b
Author: Lucas Schaff <[email protected]>
Date:   Fri Mar 3 12:20:22 2023 -0600

    Merge pull request #27 from PistolRcks/remove-prettier-ci

    Remove Prettier from CI

commit d4b230b
Author: PistolRcks <[email protected]>
Date:   Thu Mar 2 15:35:00 2023 -0600

    Remove Prettier from CI

commit 05c5b84
Merge: 2521a12 079b59c
Author: Peter Arnold <[email protected]>
Date:   Thu Mar 2 14:58:29 2023 -0600

    Signup backend testing (#24)

    Lots of additions along with the testing. Notably, Supertest is added.

commit 079b59c
Author: PistolRcks <[email protected]>
Date:   Thu Mar 2 14:52:35 2023 -0600

    Minor changes, username constraint being caught now

commit 89c391e
Author: PistolRcks <[email protected]>
Date:   Thu Mar 2 12:58:30 2023 -0600

    Consolidation of files, resolution of review comments

commit 1b0a9a5
Author: PistolRcks <[email protected]>
Date:   Wed Mar 1 09:59:53 2023 -0600

    Prettification

    Prettified all the files I modified in this PR

commit 4656395
Author: PistolRcks <[email protected]>
Date:   Wed Mar 1 09:52:53 2023 -0600

    I think tests are complete now?

    `handleUser` got changed to a callback because it's easier to test that way. Tests with callbacks now use `done` when possible as that waits until we're actually done to finish.

commit 5f61517
Author: PistolRcks <[email protected]>
Date:   Tue Feb 28 14:30:38 2023 -0600

    Adjust to review specs

commit dce066b
Author: PistolRcks <[email protected]>
Date:   Tue Feb 28 13:22:34 2023 -0600

    mock tests correctly now

    filename change to better fit to standards, also tests are mocked correctly

    current mocking solution is gross and should be reworked

commit 2521a12
Merge: de38062 f0f8b15
Author: Peter Arnold <[email protected]>
Date:   Tue Feb 21 15:02:15 2023 -0600

    Create a template for pull requests (#26)

    Pull Request Template

commit f0f8b15
Author: PistolRcks <[email protected]>
Date:   Tue Feb 21 14:55:57 2023 -0600

    Create pull_request_template.md

commit 5c4fe78
Merge: 2d65fd8 adf832f
Author: PistolRcks <[email protected]>
Date:   Tue Feb 21 14:42:26 2023 -0600

    Merge branch 'signup_backend_testing' of https://github.com/PistolRcks/web-puzzle-project into signup_backend_testing

commit 2d65fd8
Author: PistolRcks <[email protected]>
Date:   Tue Feb 21 14:41:35 2023 -0600

    Starting to work with `with-local-tmp-dir`

    Will probably just change this to mock

commit adf832f
Merge: 8c318cf de38062
Author: Peter Arnold <[email protected]>
Date:   Tue Feb 21 10:46:16 2023 -0600

    Merge branch 'master' into signup_backend_testing

commit 8c318cf
Author: PistolRcks <[email protected]>
Date:   Tue Feb 21 10:36:08 2023 -0600

    Fix import issues with validators

    `checkUsernameRequirements` and `checkPasswordRequirements` have been separated into their own files.

commit de38062
Merge: b61fb51 24e8a2c
Author: Blackkirby72 <[email protected]>
Date:   Mon Feb 20 19:52:16 2023 -0600

    Merge pull request #25 from PistolRcks/WPP6/PuzzleSelection-FrontEnd

    WPP6 Puzzle Selection Front End

commit 24e8a2c
Author: Blackkirby72 <[email protected]>
Date:   Mon Feb 20 18:10:07 2023 -0600

    testing :D

commit bd08bf3
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 17:25:01 2023 -0600

    fuckin assloads of shit

    Lots more testing. Adding Supertest. Export changes. `insertUser` changed to async

commit e3f6734
Merge: db888e7 b61fb51
Author: Blackkirby72 <[email protected]>
Date:   Mon Feb 20 16:19:14 2023 -0600

    Merge branch 'master' into WPP6/PuzzleSelection-FrontEnd

commit db888e7
Author: Blackkirby72 <[email protected]>
Date:   Mon Feb 20 16:16:05 2023 -0600

    fixed puzzle selection page too wide

commit ddb2c06
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 15:14:52 2023 -0600

    More tests...

commit c718c66
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:46:24 2023 -0600

    Integrate username/password check

commit c4c3ae7
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:41:16 2023 -0600

    Fix up such that tests begin to work

commit 1a83fe1
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:36:28 2023 -0600

    Change password and username checking to throw errors

commit 342dc6b
Merge: 181fcd4 b61fb51
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:17:24 2023 -0600

    Merge branch 'master' into signup_backend_testing

commit 181fcd4
Merge: cb9cd2d 22b578d
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:10:56 2023 -0600

    Merge branch 'master' into signup_backend_testing

commit cb9cd2d
Author: PistolRcks <[email protected]>
Date:   Mon Feb 20 14:10:30 2023 -0600

    single line looks nicer

commit b61fb51
Merge: 453375e 14789e4
Author: Peter Arnold <[email protected]>
Date:   Mon Feb 20 11:41:32 2023 -0600

    Node.js testing automation (#17)

    Sets up CI automated testing for code prettiness and Node.js testing

commit c1fdfed
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 19:17:51 2023 -0600

    pretty much done

commit 453375e
Merge: 22b578d 1e4a314
Author: kreklb <[email protected]>
Date:   Thu Feb 16 15:50:39 2023 -0600

    Merge pull request #19 from PistolRcks/account-creation

    Account creation component

commit 8a9b24d
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 15:32:35 2023 -0600

    test *should* be done

    just need to get the master branch pushed

commit 1e4a314
Author: kreklb <[email protected]>
Date:   Thu Feb 16 15:26:12 2023 -0600

    delete bundle.css

commit 30a264f
Merge: 3a2bf57 22b578d
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 15:25:02 2023 -0600

    Merge branch 'master' into WPP6/PuzzleSelection-FrontEnd

commit a406985
Merge: 4aa5e39 22b578d
Author: kreklb <[email protected]>
Date:   Thu Feb 16 15:24:06 2023 -0600

    Merge branch 'master' into account-creation

commit 22b578d
Merge: ad276b9 f838ac0
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 15:22:37 2023 -0600

    Merge pull request #21 from PistolRcks/delete-bundle-css

    Delete bundle.css

commit f838ac0
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 15:20:36 2023 -0600

    Delete bundle.css

commit 4aa5e39
Author: kreklb <[email protected]>
Date:   Thu Feb 16 15:19:07 2023 -0600

    Formatting and updating!

commit 408be4d
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 14:56:17 2023 -0600

    Start tests, put database init into own function

commit 4a9030d
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 14:34:59 2023 -0600

    Insert JSDocs

commit 3a2bf57
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 14:23:35 2023 -0600

    work

commit 926ce8e
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 14:22:46 2023 -0600

    Separate insert user callback into separate function

commit edc4677
Merge: 8835336 ad276b9
Author: Blackkirby72 <[email protected]>
Date:   Thu Feb 16 14:19:25 2023 -0600

    Merge branch 'master' into WPP6/PuzzleSelection-FrontEnd

commit d96b552
Merge: 226241c ad276b9
Author: kreklb <[email protected]>
Date:   Thu Feb 16 14:15:14 2023 -0600

    Merge branch 'master' into account-creation

commit 226241c
Author: kreklb <[email protected]>
Date:   Thu Feb 16 14:12:38 2023 -0600

    Reworked Form and added modal to LandingPage

commit ad276b9
Merge: e7401c8 7183c13
Author: kreklb <[email protected]>
Date:   Thu Feb 16 14:12:15 2023 -0600

    Merge pull request #20 from PistolRcks/landing-page-ui

    Made UI look better

commit 7183c13
Merge: e471605 e7401c8
Author: Ella Prew <[email protected]>
Date:   Thu Feb 16 13:53:35 2023 -0600

    Merge branch 'master' into landing-page-ui

commit 2c64242
Merge: c23edea e7401c8
Author: kreklb <[email protected]>
Date:   Thu Feb 16 13:12:29 2023 -0600

    Merge branch 'master' into account-creation

commit c23edea
Author: kreklb <[email protected]>
Date:   Thu Feb 16 13:11:49 2023 -0600

    Cleaned up logs

commit 14789e4
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 13:09:30 2023 -0600

    better wildcard, oops

commit 2adf608
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 13:07:50 2023 -0600

    Append Prettier CI as well

commit 26cbe60
Merge: b2d8cbb 6584f92
Author: kreklb <[email protected]>
Date:   Thu Feb 16 13:05:44 2023 -0600

    Merge branch 'master' into account-creation

commit b2d8cbb
Author: kreklb <[email protected]>
Date:   Thu Feb 16 12:56:15 2023 -0600

    Hey, my tests are done!

commit f387cee
Author: PistolRcks <[email protected]>
Date:   Thu Feb 16 12:54:19 2023 -0600

    Only use Node 18.x

commit ab09a93
Author: Peter Arnold <[email protected]>
Date:   Thu Feb 16 12:47:55 2023 -0600

    Create node_test.yml

    Creates a Github Action which automatically tests code when a PR occurs

commit 8835336
Author: Blackkirby72 <[email protected]>
Date:   Wed Feb 15 17:01:38 2023 -0600

    puzzle completion indicator + profile link

commit e471605
Author: Ella Prew <[email protected]>
Date:   Wed Feb 15 15:58:39 2023 -0600

    images and icons working

commit 2b6926c
Merge: 0446ca9 6584f92
Author: Blackkirby72 <[email protected]>
Date:   Wed Feb 15 15:57:31 2023 -0600

    Merge branch 'master' into WPP6/PuzzleSelection-FrontEnd

commit 0446ca9
Author: Blackkirby72 <[email protected]>
Date:   Wed Feb 15 15:56:34 2023 -0600

    PuzzleItem and other slight changes

commit ed6c4ad
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 17:44:26 2023 -0600

    fixed css styling, added header for puzzle selection page

commit 46f8b9f
Author: kreklb <[email protected]>
Date:   Tue Feb 14 17:01:23 2023 -0600

    Got rid of css file, added testing file, debugging last test

commit 14e7319
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 16:50:54 2023 -0600

    styled log in module and puzzle selection page to match new color scheme

commit 1756bb5
Merge: 9873b3a a7ccd3f
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 16:18:42 2023 -0600

    Merge branch 'landing-page-ui' of https://github.com/PistolRcks/web-puzzle-project into landing-page-ui

commit 9873b3a
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 16:18:39 2023 -0600

    made landing page look better

    still needs png and jpg support in order to use my pictures to make it even better

commit 77f680f
Author: kreklb <[email protected]>
Date:   Tue Feb 14 14:46:58 2023 -0600

    Account Creation

commit a7ccd3f
Merge: f7c4d87 107b9da
Author: kantab <[email protected]>
Date:   Tue Feb 14 14:35:01 2023 -0600

    Merge branch 'landing-page-ui' of https://github.com/PistolRcks/web-puzzle-project into landing-page-ui

commit f7c4d87
Author: kantab <[email protected]>
Date:   Tue Feb 14 14:34:57 2023 -0600

    changed the login form some

commit 107b9da
Merge: a64b134 52e8600
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 12:58:00 2023 -0600

    Merge branch 'master' into landing-page-ui

commit a64b134
Author: Ella Prew <[email protected]>
Date:   Tue Feb 14 12:47:09 2023 -0600

    minor changes, changed puzzlepage.js to puzzlepage.jsx

commit 1aaff92
Author: kreklb <[email protected]>
Date:   Tue Feb 14 12:17:16 2023 -0600

    Account Creation

commit ed222bc
Author: kreklb <[email protected]>
Date:   Thu Feb 9 14:41:31 2023 -0600

    Added Account Creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmschaff lmschaff lmschaff approved these changes

@connormckellips connormckellips Awaiting requested review from connormckellips

Assignees

@PistolRcks PistolRcks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PistolRcks @lmschaff