Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Support for Windows PowerShell 5.1 #443

Open
PlagueHO opened this issue Oct 9, 2021 · 1 comment
Open

Drop Support for Windows PowerShell 5.1 #443

PlagueHO opened this issue Oct 9, 2021 · 1 comment
Labels
discussion The issue is a discussion. question The issue is a question.

Comments

@PlagueHO
Copy link
Owner

PlagueHO commented Oct 9, 2021

Question: Should support be dropped for PowerShell 5.1 and below?

This will simplify some code and eliminate the need to test on PS 5.1 as part of the CI/CD processes. Some changes proposed would prevent the module from working on PowerShell 5.1 so would need to be announced that it is no longer supported.

See #442

@PlagueHO PlagueHO added question The issue is a question. discussion The issue is a discussion. labels Oct 9, 2021
@Szeraax
Copy link

Szeraax commented Oct 9, 2021

Implementing MaxRetires and RetryDelay like what Pwsh does would happen BEFORE the 429 error handling. There is no benefit to a PR for #442 in removing support for Windows Powershell. A PR for 442 will do a regular loop at lower priority than the 429 handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The issue is a discussion. question The issue is a question.
Projects
None yet
Development

No branches or pull requests

2 participants