-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up testing by automatically passing if certain files don't change #1221
Comments
Might be nice to also have a |
What if we change dependencies? That requires the whole test to run. I thought about this kind of check before but I think the best we can do is skipping notebook tests if nothing in |
So, I think the number of PR's that would benefit this kind of change is really low. But I can look into it |
Resolves #1221 I assume it will not affect a lot of PR's but some small ones (like this one or just docs update) can be faster. The conditions are, - if no change in `desc` or `requirements` don't run `notebook` tests - if no change in `desc`, `tests (without benchmarks)` or `requirements` don't run `unit` and `regression` tests - if no change in `desc`, `tests/benchmarks` or `requirements` don't run `benchmarks` If there is a change in the workflow file itself, it will run. If unit and regression tests are skipped no coverage report will be uploaded and someone has to override these PRs to merge to master. I have tried uploading 100% fake coverage report but it could have unintentional effects as Rory mentioned.
We talked about this before and in general it's tricky, but I think we can add a few simple cases:
desc
ortests
changes then unit and regression tests aren't neededdocs/notebooks
ordesc
ortests
changes then notebook tests aren't neededdesc
ortests/benchmarks
changes then benchmarks aren't neededThe text was updated successfully, but these errors were encountered: