-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Dommaschk factorials more accurate #1278
Comments
might fix some numerical issues I suspect are happening at higher resolutions in the dommaschk |
I don't know about your numerical issue but I remember that using factorials is much more accurate than gammaln, since latter uses some approximation instead of actually calculating the factorials. For non-integral numbers, that is the only choice but if |
yea but they need to be differentiable unfortunately. However... since they are a basis, I think I could make some sort of transform matrix for them and pre-compute the basis... I should look into that instead of doing this (as I just checked and I already use gammaln actually) |
Actually I cannot do that since R,Z,phi are the coordiantes and so we never have a fixed grid in them. I can, however, pre-compute all the factorials and use make a |
possibly rising factorial |
n! / m!
n! = gamma(n+1)
gammaln(n+1) = log(n!)
exp(gammaln(n+1) - gammaln(m+1)) = n!/m!
The text was updated successfully, but these errors were encountered: