Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node v20 should be used in action #91

Closed
2 tasks done
vernak2539 opened this issue Sep 5, 2024 · 3 comments
Closed
2 tasks done

[BUG] Node v20 should be used in action #91

vernak2539 opened this issue Sep 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@vernak2539
Copy link
Contributor

What happened?

When running the bpp@3, I get the info logging in the "relevant log output". The action in my repo that uses this action uses node v20 already, so I know it's not that

Which browsers are you seeing the problem on?

No response

Relevant log output

The following actions use a deprecated Node.js version and will be forced to run on node20: PlasmoHQ/bpp@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@vernak2539 vernak2539 added the bug Something isn't working label Sep 5, 2024
@louisgv
Copy link
Contributor

louisgv commented Jan 7, 2025

fixed in 70c54fd

@louisgv louisgv closed this as completed Jan 7, 2025
@vernak2539
Copy link
Contributor Author

@louisgv Thanks! I've not had a chance to test it, but it feels like this is the place it needs to be updated as well. I've not created an action before, so I could be wrong.

@vernak2539
Copy link
Contributor Author

@louisgv I've created #96 to update this. Hopefully it provides enough context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants